Alias declaration in function is not public API #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It seems that this time it's AppVeyor that is broken:
|
guwirth
reviewed
Sep 15, 2016
| template<typename Fourth> | ||
| void youpee(){ | ||
| using intrinsic_type = void; | ||
| } |
Collaborator
There was a problem hiding this comment.
@wichtounet would add also a positive test: same with comments.
Collaborator
|
@wichtounet thx looks good. @jmecosta maybe you can have a look to the AppVeyor issue. |
This commit prevents alias declaration declared at block-scope to be identified as public API. It also adds a test to ensure that it works.
wichtounet
force-pushed
the
alias_decl_fixes
branch
from
0deb3ba to
f92ce0f
Compare
Contributor
Author
|
I improved the test and pushed a new squashed commit. |
Contributor
Author
|
The build should be fixed with #950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents alias declaration declared at block-scope to be
identified as public API. It also adds a test to ensure that it
works.