Refactor EnumUtils and make it AOT-friendly.
#2200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
The `EnumUtils.Parse` method used to use the non-generic `Enum.GetValues` method to do its job, which is unsafe and produces AOT warnings. This PR refactors it to use `Enum.IsDefined` instead, which does not allocate. I also added asserts to methods in `EnumUtils` that ensure we use them with int-sized enums.
Member
|
Looks great. Thanks! |
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
I have provided test coverage for my change (where applicable)Description
The
EnumUtils.Parsemethod used to use the non-genericEnum.GetValuesmethod to do its job, which is unsafe and produces AOT warnings.This PR refactors it to use
Enum.IsDefinedinstead, which does not allocate.I also added asserts to methods in
EnumUtilsthat ensure we use them with int-sized enums.