Skip to content

Implement PackFromRgbPlanes for Rgba32 and Rgb24 #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 9, 2020
Merged

Implement PackFromRgbPlanes for Rgba32 and Rgb24 #1462

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
05db9ed
hack
antonfirsov Dec 4, 2020
7a4fbcf
entry API & tests
antonfirsov Dec 5, 2020
4e52f5e
benchmarks & scalar implementation
antonfirsov Dec 5, 2020
2177ea8
AVX2 implemetation seems to work
antonfirsov Dec 5, 2020
1242c21
started Rgba32
antonfirsov Dec 5, 2020
5943905
polishing
antonfirsov Dec 5, 2020
fee7a22
unhack
antonfirsov Dec 5, 2020
7580d7c
add benchmark results and fix PixelOperations
antonfirsov Dec 5, 2020
ae9f416
fix typo
antonfirsov Dec 5, 2020
f4107cc
revert .gitattributes
antonfirsov Dec 5, 2020
98d3160
fix build
antonfirsov Dec 5, 2020
e675710
fix scalar code
antonfirsov Dec 5, 2020
2a383b1
Merge branch 'master' into af/PackFromRgbPlanes
JimBobSquarePants Dec 6, 2020
aed233e
Merge branch 'master' into af/PackFromRgbPlanes
antonfirsov Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,8 @@
*.pvr binary
*.snk binary
*.tga binary
*.tif binary
Copy link
Member

@JimBobSquarePants JimBobSquarePants Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change comes from the automatic copy from the shared-infrastructure submodule when building.

I think you need to rebuild the solution and push again making sure all submodules are up-to-date and that the root .gitattributes and .editorconfig files are updated from the submodule on build.

Copy link
Member

@JimBobSquarePants JimBobSquarePants Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do this if you want?

Copy link
Member Author

@antonfirsov antonfirsov Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted this change.

*.tiff binary
*.ttc binary
*.ttf binary
*.wbmp binary
*.webp binary
*.woff binary
*.woff2 binary
Expand Down