Add defaultLibrary semantic token selector aliases#754
Merged
vinistock merged 2 commits intoShopify:mainfrom Mar 17, 2026
Merged
Add defaultLibrary semantic token selector aliases#754vinistock merged 2 commits intoShopify:mainfrom
defaultLibrary semantic token selector aliases#754vinistock merged 2 commits intoShopify:mainfrom
Conversation
Contributor
Author
|
Just signed the CLA! |
vinistock
reviewed
Mar 17, 2026
Contributor
Author
Done in 3cbeaf9 - thank you! |
vinistock
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the Spinel Light/Dark themes to support: Shopify/ruby-lsp#4005
In the future, we can consider removing the
variable.default_libraryselector, but I think its worth keeping for now for backwards compatibility until everyone has updated to a new version ofruby-lspwith the above change.Why
See the above PR's description for more details.