Skip to content

Conversation

@wcandillon
Copy link
Contributor

@wcandillon wcandillon commented May 29, 2024

fixes #2442

@wcandillon
Copy link
Contributor Author

@mrEuler this is work in progress but this will allow us to have test cases for the video playing logic so we can have it more stable.
About the video orientation, I will add the possibility to get the preferred SkMatrix for that video.

@mrEuler
Copy link
Contributor

mrEuler commented May 29, 2024

@wcandillon you are rock! Let's not close the issue itself, so I can post more finding there and have it as the main thread for video issues.

@wcandillon
Copy link
Contributor Author

wcandillon commented May 29, 2024 via email

@wcandillon wcandillon marked this pull request as ready for review May 29, 2024 16:02
@wcandillon wcandillon merged commit 9436209 into main May 30, 2024
@wcandillon
Copy link
Contributor Author

@mrEuler I have more improvements I want to bring to this feature but in the meantime, here we have a basis to collaborate, we can add examples, test cases, and follow different issues on the topic

@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video playback issues

2 participants