Merge pull request #595 from Shopify/dv-exec-pr

Replace file operations with Ruby methods.

Author: Mangara

job-iteration.gemspec

@@ -16,8 +16,8 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/shopify/job-iteration"
   spec.license       = "MIT"
 
-  spec.files         = %x(git ls-files -z).split("\x0").reject do |f|
-    f.match(%r{^(test|spec|features)/})
+  spec.files = ["CHANGELOG.md", "LICENSE.txt", "README.md", "job-iteration.gemspec"] + Dir.glob("{lib,exe}/**/*", File::FNM_DOTMATCH).reject do |f|
+    File.directory?(f) || f.match(%r{^(test|spec|features)/})
   end
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }

lib/job-iteration/csv_enumerator.rb

@@ -59,7 +59,7 @@ def count_of_rows_in_file
       # Behaviour of CSV#path changed in Ruby 2.6.3 (returns nil instead of raising NoMethodError)
       return unless filepath
 
-      count = %x(wc -l < #{filepath}).strip.to_i
+      count = File.foreach(filepath).count
       count -= 1 if @csv.headers
       count
     end