Skip to content

Commit 4559b33

Browse files
committed
Fix additional inflation of toff during augmentation (fixes rpng#69)
The original code was for inplace covariance operations. This caused an additional H*P_tofftoff*H^T to be added. While this shouldn't hurt it just means our covariance is conservative after augmentation. Removing doesn't seem to change simulation performance.
1 parent ef7d90f commit 4559b33

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

ov_msckf/src/state/StateHelper.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -574,8 +574,6 @@ void StateHelper::augment_clone(State *state, Eigen::Matrix<double, 3, 1> last_w
574574
state->_Cov.block(0, state->_calib_dt_CAMtoIMU->id(), state->_Cov.rows(), 1) * dnc_dt.transpose();
575575
state->_Cov.block(pose->id(), 0, 6, state->_Cov.rows()) +=
576576
dnc_dt * state->_Cov.block(state->_calib_dt_CAMtoIMU->id(), 0, 1, state->_Cov.rows());
577-
state->_Cov.block(pose->id(), pose->id(), 6, 6) +=
578-
dnc_dt * state->_Cov(state->_calib_dt_CAMtoIMU->id(), state->_calib_dt_CAMtoIMU->id()) * dnc_dt.transpose();
579577
}
580578

581579
}

0 commit comments

Comments
 (0)