sed: Support strict POSIX regexes #26429
Merged
+37
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
alimpfard
reviewed
Nov 26, 2025
Member
alimpfard
left a comment
alimpfard
left a comment
There was a problem hiding this comment.
Please squash all the fixup commits into the main one, something something commit guidelines.
Userland/Utilities/sed.cpp
Outdated
Comment on lines
874
to
878
| ByteString result; | ||
| if (s_args.regex.has<Regex<PosixExtended>>()) { | ||
| result = s_args.regex.get<Regex<PosixExtended>>().replace(pattern_space_sv, s_args.replacement, s_args.options); | ||
| } else { | ||
| result = s_args.regex.get<Regex<PosixBasic>>().replace(pattern_space_sv, s_args.replacement, s_args.options); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| ByteString result; | |
| if (s_args.regex.has<Regex<PosixExtended>>()) { | |
| result = s_args.regex.get<Regex<PosixExtended>>().replace(pattern_space_sv, s_args.replacement, s_args.options); | |
| } else { | |
| result = s_args.regex.get<Regex<PosixBasic>>().replace(pattern_space_sv, s_args.replacement, s_args.options); | |
| } | |
| auto result = s_args.regex.visit([&](auto& re) { return re.replace(pattern_space_sv, s_args.replacement, s_args.options); }); |
cofinalsubnets
force-pushed
the
gwen/posix-compat
branch
from
114362c to
974639c
Compare
Adds command line flags to `sed` to require strict POSIX behavior. Extended regexes are still used by default but an ignored -E flag is added for compatibility with other sed versions.
cofinalsubnets
force-pushed
the
gwen/posix-compat
branch
from
974639c to
388dd1b
Compare
Member
|
Thank you! |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds command line flags to
sedto require strict POSIX behavior. Extended regexes are still used by default but an ignored -E flag is added for compatibility with other sed versions.