Kernel+CrashDaemon: Use a ".partial" suffix for incomplete coredumps #26390
+39
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
spholz
reviewed
Nov 12, 2025
Member
|
commit message nit: s/prefix/suffix |
spholz
added
⏳ pr-waiting-for-author
LucasChollet
changed the title
github-actions
bot
added
👀 pr-needs-review
LucasChollet
force-pushed
the
crash_daemon
branch
from
824d5bf to
f7b6843
Compare
The Kernel will now write to a .partial file until it is done writing, and then rename the file by removing the extension. This makes the final coredump appear atomically on the file system and thus remove the need for special handling of partial files in CrashDaemon.
LucasChollet
force-pushed
the
crash_daemon
branch
from
f7b6843 to
99312a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kernel will now write to a .partial file until it is done writing, and then rename the file by removing the extension.
This makes the final coredump appear atomically on the file system. So no need for special handling of partial files in CrashDaemon.