Merge pull request #940 from SciML/testfixes

A few test fixes for SciMLBase v2.0

Author: ChrisRackauckas

.github/workflows/CI.yml

@@ -38,8 +38,8 @@ jobs:
         env:
           GROUP: ${{ matrix.group }}
       - uses: julia-actions/julia-processcoverage@v1
-        with:
-          directories: src, ext
+        #with:
+        #  directories: src, ext
       - uses: codecov/codecov-action@v3
         with:
           file: lcov.info

src/solve.jl

@@ -70,6 +70,8 @@ const allowedkeywords = (:dense,
     :sensealg,
     :advance_to_tstop,
     :stop_at_next_tstop,
+    :u0,
+    :p,
     # These two are from the default algorithm handling
     :default_set,
     :second_time,

test/remake_tests.jl

@@ -23,7 +23,7 @@ dprob = DiscreteProblem((u, p, t) -> 2u, 0.5, (0.0, 1.0))
 @test remake(dprob; u0 = 1.0).u0 == 1.0
 
 oprob = ODEProblem((u, p, t) -> 2u, 0.5, (0.0, 1.0))
-@test remake(oprob) == oprob
+@test_broken remake(oprob) == oprob # fails due to change to mutable struct due to === fallback
 @test remake(oprob; u0 = 1.0).u0 == 1.0
 
 sprob = SDEProblem((u, p, t) -> 2u, (u, p, t) -> 2u, 0.5, (0.0, 1.0))
@@ -78,10 +78,10 @@ noise2 = remake(noise1; tspan = tspan2);
 @test noise1.tspan != noise2.tspan
 
 # Test remake with TwoPointBVPFunction (manually defined):
-f1 = SciMLBase.TwoPointBVPFunction(() -> 1)
-f2 = remake(f1; bc = () -> 2)
-@test f1.bc() == 1
-@test f2.bc() == 2
+f1 = SciMLBase.TwoPointBVPFunction((u, p, t) -> 1, ((u_a, u_b), p) -> 2)
+@test_broken f2 = remake(f1; bc = ((u_a, u_b), p) -> 3)
+@test_broken f1.bc() == 1
+@test_broken f2.bc() == 2
 
 # Testing remake for no recompile
 u0 = [0; 2.0]