Skip to content

Commit 843380e

Browse files
leander-dsouzaSakshayMahna
authored andcommitted
Mypy nav2 lifecycle manager (ros-navigation#5051)
* Configured nav2_lifecycle_manager to be compatible with mypy Signed-off-by: Leander Stephen D'Souza <[email protected]> * Added nav2_lifecycle_manager to the workflow. Signed-off-by: Leander Stephen D'Souza <[email protected]> --------- Signed-off-by: Leander Stephen D'Souza <[email protected]> Signed-off-by: Sakshay Mahna <[email protected]>
1 parent bc62aa5 commit 843380e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/lint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ jobs:
3434
- "nav2_collision_monitor"
3535
- "nav2_costmap_2d"
3636
- "opennav_docking"
37+
- "nav2_lifecycle_manager"
3738
steps:
3839
- uses: actions/checkout@v4
3940

nav2_lifecycle_manager/test/launch_bond_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from launch_testing.legacy import LaunchTestService
2323

2424

25-
def generate_launch_description():
25+
def generate_launch_description() -> LaunchDescription:
2626
return LaunchDescription(
2727
[
2828
Node(
@@ -40,7 +40,7 @@ def generate_launch_description():
4040
)
4141

4242

43-
def main(argv=sys.argv[1:]):
43+
def main(argv: list[str] = sys.argv[1:]): # type: ignore[no-untyped-def]
4444
ld = generate_launch_description()
4545

4646
testExecutable = os.getenv('TEST_EXECUTABLE')

nav2_lifecycle_manager/test/launch_lifecycle_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from launch_testing.legacy import LaunchTestService
2323

2424

25-
def generate_launch_description():
25+
def generate_launch_description() -> LaunchDescription:
2626
return LaunchDescription(
2727
[
2828
Node(
@@ -41,7 +41,7 @@ def generate_launch_description():
4141
)
4242

4343

44-
def main(argv=sys.argv[1:]):
44+
def main(argv: list[str] = sys.argv[1:]): # type: ignore[no-untyped-def]
4545
ld = generate_launch_description()
4646

4747
testExecutable = os.getenv('TEST_EXECUTABLE')

0 commit comments

Comments
 (0)