Skip to content

Commit 3e16f99

Browse files
ingridwangSaadnajmi
authored andcommitted
Delete empty didRegisterUserNotificationSettings (facebook#41013)
Summary: Pull Request resolved: facebook#41013 [iOS][Breaking] Deleted the no-op didRegisterUserNotificationSettings: callback in RCTPushNotificationManager Reviewed By: philIip Differential Revision: D50283620 fbshipit-source-id: 1582367c51c26e5b739cd9284d3b15bfa13274da
1 parent be945a3 commit 3e16f99

3 files changed

Lines changed: 0 additions & 18 deletions

File tree

packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ typedef void (^RCTRemoteNotificationCallback)(UIBackgroundFetchResult result);
1616
#endif // [macOS]
1717

1818
#if !TARGET_OS_UIKITFORMAC
19-
#if !TARGET_OS_OSX // [macOS]
20-
+ (void)didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings;
21-
#endif // [macOS]
2219
+ (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken;
2320
+ (void)didReceiveRemoteNotification:(NSDictionary *)notification;
2421
#if !TARGET_OS_OSX // [macOS]

packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -235,12 +235,6 @@ - (void)stopObserving
235235
];
236236
}
237237

238-
#if !TARGET_OS_OSX // [macOS]
239-
+ (void)didRegisterUserNotificationSettings:(__unused UIUserNotificationSettings *)notificationSettings
240-
{
241-
}
242-
#endif // [macOS]
243-
244238
+ (void)didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
245239
{
246240
NSMutableString *hexString = [NSMutableString string];

packages/rn-tester/RNTester/AppDelegate.mm

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -338,15 +338,6 @@ - (void)registerPaperComponents:(NSArray<NSString *> *)components
338338

339339
#if !TARGET_OS_TV && !TARGET_OS_UIKITFORMAC
340340

341-
#if !TARGET_OS_OSX // [macOS]
342-
// Required to register for notifications
343-
- (void)application:(__unused UIApplication *)application
344-
didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings
345-
{
346-
[RCTPushNotificationManager didRegisterUserNotificationSettings:notificationSettings];
347-
}
348-
#endif // [macOS]
349-
350341
// Required for the remoteNotificationsRegistered event.
351342
- (void)application:(__unused RCTUIApplication *)application
352343
didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken

0 commit comments

Comments
 (0)