ldap: fail to login if neither the username nor the password are present

It's not needed to reach the LDAP server when neither of these values are
present, since this should fail anyways. This fixes a common pitfall on LDAP
servers that have not been configured to handle this special case.

Signed-off-by: Miquel Sabaté Solà <[email protected]>

Author: mssola

lib/portus/ldap.rb

@@ -90,6 +90,7 @@ def load_configuration
 
       fill_user_params!
       return nil if params[:user].nil?
+      return nil if params[:user][:username].blank? || params[:user][:password].blank?
 
       adapter.new(adapter_options)
     end

spec/lib/portus/ldap_spec.rb

@@ -143,6 +143,15 @@ def load_configuration_test
     lm = PortusMock.new(account: "portus", password: "1234")
     expect(lm.load_configuration_test).to be nil
 
+    # Empty password always returns an empty configuration
+    lm = LdapMock.new(username: "name", password: "")
+    expect(lm.load_configuration_test).to be nil
+
+    # Empty name always returns an empty configuration
+    lm = LdapMock.new(username: "", password: "1234")
+    expect(lm.load_configuration_test).to be nil
+
+    # Now we are good to go
     lm = LdapMock.new(username: "name", password: "1234")
     cfg = lm.load_configuration_test
 
@@ -302,10 +311,9 @@ def load_configuration_test
 
     it "raises an exception if the user could not created" do
       APP_CONFIG["ldap"] = { "enabled" => true, "base" => "" }
-      lm = LdapMock.new(username: "", password: "1234")
+      lm = LdapMock.new(username: "name", password: "1234")
       lm.authenticate!
-      expect(lm.last_symbol).to eq "Password is too short (minimum is 8 characters),"\
-        "Username Only alphanumeric characters are allowed. Minimum 4 characters, maximum 30."
+      expect(lm.last_symbol).to eq "Password is too short (minimum is 8 characters)"
     end
 
     it "returns a success if it was successful" do