GatewayAPI HTTPRoute timeout

Implementation to support POC on HTTRoute Timeouts for GatewayAPI

 references:
* kubernetes-sigs/gateway-api#2013
* https://gateway-api.sigs.k8s.io/geps/gep-1742/
* https://gateway-api.sigs.k8s.io/geps/gep-2257/
* kubernetes-sigs/gateway-api#1742
* kubernetes-sigs/gateway-api#1997

Author: SRodi

go.mod

@@ -250,3 +250,5 @@ require (
 	sigs.k8s.io/kustomize/kyaml v0.14.3 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.3.0 // indirect
 )
+
+replace sigs.k8s.io/gateway-api => /Users/simone/go/src/sigs.k8s.io/gateway-api

pilot/pkg/config/kube/gateway/conversion.go

@@ -22,6 +22,7 @@ import (
 	"sort"
 	"strings"
 
+	"google.golang.org/protobuf/types/known/durationpb"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	klabels "k8s.io/apimachinery/pkg/labels"
 	k8s "sigs.k8s.io/gateway-api/apis/v1alpha2"
@@ -42,6 +43,8 @@ import (
 	"istio.io/istio/pkg/ptr"
 	"istio.io/istio/pkg/slices"
 	"istio.io/istio/pkg/util/sets"
+
+	time "time"
 )
 
 func sortConfigByCreationTime(configs []config.Config) {
@@ -271,6 +274,26 @@ func convertHTTPRoute(r k8s.HTTPRouteRule, ctx configContext,
 		return vs, backendErr
 	}
 
+	if r.Timeouts != nil {
+		if r.Timeouts.Request != nil {
+			request, _ := time.ParseDuration((string)(*r.Timeouts.Request))
+			if request != 0 {
+				vs.Timeout = durationpb.New(request)
+			}
+		}
+		if r.Timeouts.BackendRequest != nil {
+			backendRequest, _ := time.ParseDuration((string)(*r.Timeouts.BackendRequest))
+			if backendRequest != 0 {
+				timeout := durationpb.New(backendRequest)
+				if vs.Retries != nil {
+					vs.Retries.PerTryTimeout = timeout
+				} else {
+					vs.Timeout = timeout
+				}
+			}
+		}
+	}
+
 	return vs, nil
 }
 

pilot/pkg/config/kube/gateway/testdata/http.status.yaml.golden

@@ -36,7 +36,7 @@ status:
     status: "True"
     type: Programmed
   listeners:
-  - attachedRoutes: 6
+  - attachedRoutes: 8
     conditions:
     - lastTransitionTime: fake
       message: No errors found
@@ -117,6 +117,56 @@ status:
 ---
 apiVersion: gateway.networking.k8s.io/v1beta1
 kind: HTTPRoute
+metadata:
+  creationTimestamp: null
+  name: http-timeout-backend-request
+  namespace: default
+spec: null
+status:
+  parents:
+  - conditions:
+    - lastTransitionTime: fake
+      message: Route was valid
+      reason: Accepted
+      status: "True"
+      type: Accepted
+    - lastTransitionTime: fake
+      message: All references resolved
+      reason: ResolvedRefs
+      status: "True"
+      type: ResolvedRefs
+    controllerName: istio.io/gateway-controller
+    parentRef:
+      name: gateway
+      namespace: istio-system
+---
+apiVersion: gateway.networking.k8s.io/v1beta1
+kind: HTTPRoute
+metadata:
+  creationTimestamp: null
+  name: http-timeout-request
+  namespace: default
+spec: null
+status:
+  parents:
+  - conditions:
+    - lastTransitionTime: fake
+      message: Route was valid
+      reason: Accepted
+      status: "True"
+      type: Accepted
+    - lastTransitionTime: fake
+      message: All references resolved
+      reason: ResolvedRefs
+      status: "True"
+      type: ResolvedRefs
+    controllerName: istio.io/gateway-controller
+    parentRef:
+      name: gateway
+      namespace: istio-system
+---
+apiVersion: gateway.networking.k8s.io/v1beta1
+kind: HTTPRoute
 metadata:
   creationTimestamp: null
   name: http2

pilot/pkg/config/kube/gateway/testdata/http.yaml

@@ -214,4 +214,47 @@ spec:
         value: /get
     backendRefs:
     - name: httpbin-bad
-      port: 80
+      port: 80
+---
+apiVersion: gateway.networking.k8s.io/v1beta1
+kind: HTTPRoute
+metadata:
+  name: http-timeout-request
+  namespace: default
+spec:
+  parentRefs:
+  - name: gateway
+    namespace: istio-system
+  hostnames: ["timeout.domain.example"]
+  rules:
+  - matches:
+    - path:
+        type: PathPrefix
+        value: /get
+    backendRefs:
+    - name: httpbin
+      port: 80
+    timeouts:
+      request: 1ms
+---
+apiVersion: gateway.networking.k8s.io/v1beta1
+kind: HTTPRoute
+metadata:
+  name: http-timeout-backend-request
+  namespace: default
+spec:
+  parentRefs:
+  - name: gateway
+    namespace: istio-system
+  hostnames: ["timeout-backend.domain.example"]
+  rules:
+  - matches:
+    - path:
+        type: PathPrefix
+        value: /get
+    backendRefs:
+    - name: httpbin
+      port: 80
+    timeouts:
+      request: 2ms
+      backendRequest: 1ms

pilot/pkg/config/kube/gateway/testdata/http.yaml.golden

@@ -96,6 +96,58 @@ spec:
 ---
 apiVersion: networking.istio.io/v1alpha3
 kind: VirtualService
+metadata:
+  annotations:
+    internal.istio.io/parents: HTTPRoute/http-timeout-backend-request.default
+    internal.istio.io/route-semantics: gateway
+  creationTimestamp: null
+  name: http-timeout-backend-request-0-istio-autogenerated-k8s-gateway
+  namespace: default
+spec:
+  gateways:
+  - istio-system/gateway-istio-autogenerated-k8s-gateway-default
+  hosts:
+  - timeout-backend.domain.example
+  http:
+  - match:
+    - uri:
+        prefix: /get
+    name: default.http-timeout-backend-request.0
+    route:
+    - destination:
+        host: httpbin.default.svc.domain.suffix
+        port:
+          number: 80
+    timeout: 0.001s
+---
+apiVersion: networking.istio.io/v1alpha3
+kind: VirtualService
+metadata:
+  annotations:
+    internal.istio.io/parents: HTTPRoute/http-timeout-request.default
+    internal.istio.io/route-semantics: gateway
+  creationTimestamp: null
+  name: http-timeout-request-0-istio-autogenerated-k8s-gateway
+  namespace: default
+spec:
+  gateways:
+  - istio-system/gateway-istio-autogenerated-k8s-gateway-default
+  hosts:
+  - timeout.domain.example
+  http:
+  - match:
+    - uri:
+        prefix: /get
+    name: default.http-timeout-request.0
+    route:
+    - destination:
+        host: httpbin.default.svc.domain.suffix
+        port:
+          number: 80
+    timeout: 0.001s
+---
+apiVersion: networking.istio.io/v1alpha3
+kind: VirtualService
 metadata:
   annotations:
     internal.istio.io/parents: HTTPRoute/http2.default