-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(@inquirer/prompts-i18n) New i18n package with first set of localization #1892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
11e8e1e to
37a2624
Compare
1d5c3cf to
fd21432
Compare
| confirm: { | ||
| yesLabel: '是', | ||
| noLabel: '否', | ||
| hintYes: '是/否', | ||
| hintNo: '是/否', | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LitoMore Wondering if that's a good internationalization for non-latin languages 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use bold text for the default choice.
hintYes: 是/否
hintNo: 是/否
Or use with English:
yesLabel: '是(Yes)',
noLabel: '否(No)',
hintYes: '是(Y)/否(n)',
hintNo: '是(y)/否(N)',
| @@ -0,0 +1,114 @@ | |||
| <img width="75px" height="75px" align="right" alt="Inquirer Logo" src="https://raw.githubusercontent.com/SBoudrias/Inquirer.js/main/assets/inquirer_readme.svg?sanitize=true" title="Inquirer.js"/> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: gotta edit README and adding a contribution guide.
37a2624 to
a82760b
Compare
fd21432 to
25051d0
Compare
8a985d5 to
f0e9c85
Compare
25051d0 to
1831ec4
Compare
c5db0e9 to
8ca20d4
Compare
1831ec4 to
3e69240
Compare
3e69240 to
03454e6
Compare
| @@ -0,0 +1,152 @@ | |||
| import { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD might review having the index resolve the user locale based on process.env.LANG and having a @inquirer/prompts-i18n/create export 🤷🏻
Early PR adding a new package structure.
Still TODO: