This repository was archived by the owner on Aug 2, 2024. It is now read-only.
feat: create focus trap mixin and add it to modal #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
For accessibility reasons we added a tabindex to the modal as well (e.g. for reading out the title). This As a result the browsers create a default outline when the modal gets focussed. |
Contributor
ChristianKienle
left a comment
ChristianKienle
left a comment
There was a problem hiding this comment.
So I ran the Modal demo locally with your changes and everything worked nicely. Feels much better. I have a question regarding the mixin. See my comment.
albrechtjohannes
force-pushed
the
feat/modal-keyboard-navigation
branch
from
9716cac to
f20725f
Compare
ChristianKienle
approved these changes
Mar 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue
#236
Summary
This PR improves the accessibility of the modal component by adding a focus trap that is bound to the modal when opening it. To achieve this, I added a dependency to https://github.com/davidtheclark/focus-trap and a mixin, which is currently used only in the modal. However, it could also be used in other components, for example the popover component.