fix: update currentYear on date selection #363
Conversation
| this.setState({ | ||
| currentDateDisplayed: date, | ||
| currentYear: date, | ||
| selectedDate: date, |
There was a problem hiding this comment.
Is it strange that we have 3 different state variables (currentDateDisplayed, currentYear, selectedDate) that are all being set to the same value? Seems like they should either be set to different values or the code that depends on them should just reference a single stored value.
There was a problem hiding this comment.
@greg-a-smith I agree, but I think it might be better to save that work for an overall refactoring effort instead of putting more time into this. Thoughts?
There was a problem hiding this comment.
@jbadan Agreed. That's probably a much larger effort.
There was a problem hiding this comment.
I agree we should refactor this control. as a side not i did remove the currentYear property and updated the code and tests to work off the currentDateDisplayed property instead 😄
greg-a-smith
left a comment
greg-a-smith
left a comment
There was a problem hiding this comment.
I like this better! 🚢
* fix: update currentYear on date selection * removed currentYear prop
Description
Set the currentYear value to the selected date object.
fixes #357