fix: DatePicker update unit tests #332
Conversation
chrismanciero
requested review from
a team,
bcullman,
greg-a-smith and
jbadan
src/DatePicker/DatePicker.test.js
Outdated
| // check to make sure calendar is shown | ||
| expect(wrapper.state('hidden')).toBeFalsy(); | ||
|
|
||
| // click to hide calendar |
There was a problem hiding this comment.
This seems like the wrong comment. It's simulating a click in the input, which based on the next assertion, should not hide the calendar.
There was a problem hiding this comment.
@greg-a-smith - thanks for noticing, i just updated the comment
| let event = new MouseEvent('mousedown', { | ||
| target: document.querySelector('body') | ||
| }); | ||
| document.dispatchEvent(event); |
There was a problem hiding this comment.
I don't understand why the added mousedown event, but then no additional assertions. I'm probably just missing something.
There was a problem hiding this comment.
removed MouseEvent code since it was not necessary
There was a problem hiding this comment.
I am still seeing a couple of these in the files changed diff.
There was a problem hiding this comment.
sorry, missed that mouseDown event. Just added an assertion to check that calendar is hidden.
| let event = new MouseEvent('mousedown', { | ||
| target: document.querySelector('body') | ||
| }); | ||
| document.dispatchEvent(event); |
There was a problem hiding this comment.
I don't understand why the added mousedown event, but then no additional assertions. I'm probably just missing something.
There was a problem hiding this comment.
added assertion to check that calendar is hidden
src/DatePicker/DatePicker.test.js
Outdated
|
|
||
|
|
||
| // press Esc key | ||
| wrapper.find('input[type="text"]').simulate('keypress', { key: 'Esc' }); |
There was a problem hiding this comment.
Shouldn't each test block end with an assertion?
There was a problem hiding this comment.
Added assertions at the end of test
* fix: update unit tests * fix comments, remove unnecessary test code * added assertion check after MouseDown event
Description
Update unit tests for DatePicker component