Skip to content

Commit e6d3287

Browse files
authored
fix: Refactor SideNavigation to remove React-Router dependency (#372)
* Save state * saving state * Adding interactivity and active item * Updating Unit Tests * Downgrading React-Router-* to devDependencies * Add Prop Descriptons * Normalized SideNavGroup into SideNavList & renamed SIdeNavSubItems to SideNavSubList * Removing SubList and Refactoring in SideNavList * Remove expanded tracking from SideNav and pushing into SideNavListItem * Linting fixes * Adding focus-trap after removing it * Package-lock was not in sync * PR feedback * Updating children prop type * Fixing issue where parent items were being selectd. Also updated documentation * Correcting testing issue * Updates to prop descriptions
1 parent 0cfef6d commit e6d3287

File tree

7 files changed

+1149
-594
lines changed

7 files changed

+1149
-594
lines changed

package-lock.json

Lines changed: 36 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@
4545
"dependencies": {
4646
"classnames": "^2.2.6",
4747
"fiori-fundamentals": "^1.4.0",
48-
"focus-trap-react": "^6.0.0",
49-
"react-router": "^4.3.1",
50-
"react-router-dom": "^4.3.1"
48+
"focus-trap-react": "^6.0.0"
5149
},
5250
"devDependencies": {
5351
"@babel/cli": "^7.1.5",
@@ -114,6 +112,8 @@
114112
"react-dev-utils": "^6.1.1",
115113
"react-dom": "^16.6.3",
116114
"react-markdown": "^4.0.6",
115+
"react-router": "^4.3.1",
116+
"react-router-dom": "^4.3.1",
117117
"react-syntax-highlighter": "^9.0.1",
118118
"react-test-renderer": "^16.6.3",
119119
"resolve": "1.8.1",

0 commit comments

Comments
 (0)