fix: prevent disabled and readonly select from opening (#1124)

* fix: disabled and readonly select disable opening

* fix: adjust logic

* fix: add back onclick

Author: jacobdevera

src/Select/Select.js

@@ -105,7 +105,6 @@ const Select = React.forwardRef(({
             {...props}
             className={selectClasses}
             id={id}
-            onClick={handleClick}
             ref={divRef}>
             <div className={selectControlClasses}>
                 <span aria-label={selectAriaLabel} className='fd-select__text-content'>{textContent}</span>
@@ -114,12 +113,16 @@ const Select = React.forwardRef(({
         </div>
     );
 
+    const tabIndex = disabled ? -1 : 0;
+
     const wrappedSelectControl = (
         <FormValidationOverlay
             aria-disabled={disabled}
             aria-readonly={readOnly}
             control={selectControl}
+            onClick={handleClick}
             role={'combobox'}
+            tabIndex={tabIndex}
             validationState={validationState} />
     );
 
@@ -162,6 +165,8 @@ const Select = React.forwardRef(({
                     </List>
                 </>)}
             control={wrappedSelectControl}
+            disableKeyPressHandler={disabled || readOnly}
+            disableTriggerOnClick={disabled || readOnly}
             firstFocusIndex={firstFocusIndex}
             noArrow
             placement='bottom-start'

src/Select/__stories__/__snapshots__/Select.stories.storyshot

@@ -152,15 +152,11 @@ exports[`Storyshots Component API/Select Disabled 1`] = `
               className="fd-popover__control"
             >
               <div
-                aria-controls="fd-mocked-short-id"
                 aria-disabled={true}
-                aria-expanded={false}
-                aria-haspopup="listbox"
                 className="fd-select"
                 onClick={[Function]}
-                onKeyPress={[Function]}
                 role="combobox"
-                tabIndex={0}
+                tabIndex={-1}
               >
                 <div
                   className="fd-select__control is-disabled"
@@ -334,13 +330,9 @@ exports[`Storyshots Component API/Select Read Only 1`] = `
               className="fd-popover__control"
             >
               <div
-                aria-controls="fd-mocked-short-id"
-                aria-expanded={false}
-                aria-haspopup="listbox"
                 aria-readonly={true}
                 className="fd-select"
                 onClick={[Function]}
-                onKeyPress={[Function]}
                 role="combobox"
                 tabIndex={0}
               >