chore: 🤖 [3155|3154]removed deprecated code#1559
Merged
Conversation
SwiftUI: remove deprecated code for FilterFeedbackBarButtonModel, FilterFeedbackBarItemModel and SortViewModel
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| guard let nextValue = nextValue() else { return } | ||
| value = nextValue | ||
| } | ||
| } |
There was a problem hiding this comment.
File Length Violation: File should contain 700 lines or less: currently contains 1360 (file_length)
Collaborator
|
/summarize |
xiaoyu0722
requested changes
Feb 11, 2026
| } | ||
| */ | ||
| /// Option list picker configuration for styling | ||
| public struct OptionListPickerButtonConfiguration { |
Contributor
There was a problem hiding this comment.
Seems, these are used for deprecated components, I think we should remove them also.
Collaborator
Author
There was a problem hiding this comment.
OptionListPickerButtonConfiguration used in new component, removed OptionListPickerItem
xiaoyu0722
approved these changes
Feb 12, 2026
Collaborator
Author
|
Resolved conflicts |
dyongxu
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftUI: remove deprecated code for FilterFeedbackBarButtonModel, FilterFeedbackBarItemModel and SortViewModel