-
Notifications
You must be signed in to change notification settings - Fork 226
cipher: fix seeking implementation in the stream cipher wrapper #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is this really a fix for #1808? I would think a real fix would make the last keystream block usable |
|
See my comment in the issue. I spent a significant time trying to implement the last byte approach, but I couldn't get a satisfying solution. |
|
Another alternative could be to add a special "exhausted" state to the wrapper (either as a separate field, or as part of Considering that users arguably should not rely on the last keystream block in practice, I am not sure it's worth the trouble. |
|
@tarcieri |
tarcieri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good to me
The change forbids seeking to the last keystream block and its application. Additionally, unchecked methods added as an escape hatch.
Closes #1808