Derive Sequence for pkcs1 types

This reduces the amount of custom code that is written.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Author: npmccallum

pkcs1/src/private_key/other_prime_info.rs

@@ -1,6 +1,6 @@
 //! PKCS#1 OtherPrimeInfo support.
 
-use der::{asn1::UIntBytes, Decodable, Decoder, Encodable, Sequence};
+use der::{asn1::UIntBytes, Sequence};
 
 /// PKCS#1 OtherPrimeInfo as defined in [RFC 8017 Appendix 1.2].
 ///
@@ -15,7 +15,7 @@ use der::{asn1::UIntBytes, Decodable, Decoder, Encodable, Sequence};
 /// ```
 ///
 /// [RFC 8017 Appendix 1.2]: https://datatracker.ietf.org/doc/html/rfc8017#appendix-A.1.2
-#[derive(Clone)]
+#[derive(Clone, Sequence)]
 #[cfg_attr(docsrs, doc(cfg(feature = "alloc")))]
 pub struct OtherPrimeInfo<'a> {
     /// Prime factor `r_i` of `n`, where `i` >= 3.
@@ -27,24 +27,3 @@ pub struct OtherPrimeInfo<'a> {
     /// CRT coefficient: `t_i = (r_1 * r_2 * ... * r_(i-1))^(-1) mod r_i`.
     pub coefficient: UIntBytes<'a>,
 }
-
-impl<'a> Decodable<'a> for OtherPrimeInfo<'a> {
-    fn decode(decoder: &mut Decoder<'a>) -> der::Result<Self> {
-        decoder.sequence(|decoder| {
-            Ok(Self {
-                prime: decoder.decode()?,
-                exponent: decoder.decode()?,
-                coefficient: decoder.decode()?,
-            })
-        })
-    }
-}
-
-impl<'a> Sequence<'a> for OtherPrimeInfo<'a> {
-    fn fields<F, T>(&self, f: F) -> der::Result<T>
-    where
-        F: FnOnce(&[&dyn Encodable]) -> der::Result<T>,
-    {
-        f(&[&self.prime, &self.exponent, &self.coefficient])
-    }
-}

pkcs1/src/public_key.rs

@@ -4,7 +4,7 @@
 pub(crate) mod document;
 
 use crate::{Error, Result};
-use der::{asn1::UIntBytes, Decodable, Decoder, Encodable, Sequence};
+use der::{asn1::UIntBytes, Decodable, Sequence};
 
 #[cfg(feature = "alloc")]
 use crate::RsaPublicKeyDocument;
@@ -24,7 +24,7 @@ use {crate::LineEnding, alloc::string::String, der::Document};
 /// ```
 ///
 /// [RFC 8017 Appendix 1.1]: https://datatracker.ietf.org/doc/html/rfc8017#appendix-A.1.1
-#[derive(Copy, Clone, Debug, Eq, PartialEq)]
+#[derive(Copy, Clone, Debug, Eq, PartialEq, Sequence)]
 pub struct RsaPublicKey<'a> {
     /// `n`: RSA modulus
     pub modulus: UIntBytes<'a>,
@@ -50,26 +50,6 @@ impl<'a> RsaPublicKey<'a> {
     }
 }
 
-impl<'a> Decodable<'a> for RsaPublicKey<'a> {
-    fn decode(decoder: &mut Decoder<'a>) -> der::Result<Self> {
-        decoder.sequence(|decoder| {
-            Ok(Self {
-                modulus: decoder.decode()?,
-                public_exponent: decoder.decode()?,
-            })
-        })
-    }
-}
-
-impl<'a> Sequence<'a> for RsaPublicKey<'a> {
-    fn fields<F, T>(&self, f: F) -> der::Result<T>
-    where
-        F: FnOnce(&[&dyn Encodable]) -> der::Result<T>,
-    {
-        f(&[&self.modulus, &self.public_exponent])
-    }
-}
-
 impl<'a> TryFrom<&'a [u8]> for RsaPublicKey<'a> {
     type Error = Error;