Skip to content

Commit c850e7d

Browse files
committed
refactor: expect digest passed to be a hashed typed data already
1 parent 1c646f0 commit c850e7d

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

src/validator/SessionKeyOwnedValidator.sol

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,19 @@ contract SessionKeyOwnedValidator is IKernelValidator {
4040
address recovered = ECDSA.recover(hash, _userOp.signature);
4141

4242
SessionKeyStorage storage sessionKey = sessionKeyStorage[recovered][msg.sender];
43-
if (sessionKey.validUntil == 0 ) { // we do not allow validUntil == 0 here
43+
if (sessionKey.validUntil == 0) {
44+
// we do not allow validUntil == 0 here
4445
return SIG_VALIDATION_FAILED;
4546
}
4647
return _packValidationData(false, sessionKey.validUntil, sessionKey.validAfter);
4748
}
4849

4950
function validateSignature(bytes32 hash, bytes calldata signature) public view override returns (uint256) {
50-
bytes32 ethhash = ECDSA.toEthSignedMessageHash(hash);
51-
address recovered = ECDSA.recover(ethhash, signature);
51+
address recovered = ECDSA.recover(hash, signature);
5252

5353
SessionKeyStorage storage sessionKey = sessionKeyStorage[recovered][msg.sender];
54-
if (sessionKey.validUntil == 0 ) { // we do not allow validUntil == 0 here
54+
if (sessionKey.validUntil == 0) {
55+
// we do not allow validUntil == 0 here
5556
return SIG_VALIDATION_FAILED;
5657
}
5758
return _packValidationData(false, sessionKey.validUntil, sessionKey.validAfter);

0 commit comments

Comments
 (0)