-
Notifications
You must be signed in to change notification settings - Fork 17
Update codequality.js #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-code-quality
Are you sure you want to change the base?
Conversation
| } | ||
| } | ||
| } | ||
| function f1(a, b) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generic or short names make code hard to understand. More info
| return x + y; | ||
| } | ||
|
|
||
| class C { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generic or short names make code hard to understand. More info
| } | ||
|
|
||
| class C { | ||
| constructor(d) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generic or short names make code hard to understand. More info
|
|
||
| class C { | ||
| constructor(d) { | ||
| this.d = d; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generic or short names make code hard to understand. More info
| this.d = d; | ||
| } | ||
|
|
||
| doIt() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generic or short names make code hard to understand. More info
| } | ||
|
|
||
| doIt() { | ||
| let r = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generic or short names make code hard to understand. More info
| } | ||
| } | ||
| } | ||
| function f1(a, b) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long functions are difficult to understand, test, and maintain. More info
| } | ||
|
|
||
| doIt() { | ||
| let r = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very short variable names make code unclear. More info
| } | ||
| } | ||
| } | ||
| function f1(a, b) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions without comments are hard to understand for other developers. More info
| return x + y; | ||
| } | ||
|
|
||
| class C { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions without comments are hard to understand for other developers. More info
| this.d = d; | ||
| } | ||
|
|
||
| doIt() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions without comments are hard to understand for other developers. More info
| y -= k; | ||
| } | ||
| } | ||
| console.log("Result is: " + (x + y)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines that are too long are difficult to read and navigate, especially on smaller screens. More info
No description provided.