Fix vp8 in kinetic add vp9 and h264 support#52
Merged
jihoonl merged 4 commits intoRobotWebTools:developfrom Jan 28, 2018
randoms:fix_vp8
Merged
Fix vp8 in kinetic add vp9 and h264 support#52jihoonl merged 4 commits intoRobotWebTools:developfrom randoms:fix_vp8
jihoonl merged 4 commits intoRobotWebTools:developfrom
randoms:fix_vp8
Conversation
added 2 commits
January 8, 2018 16:59
|
I get this: when I try to use type=vp8 or vp9. |
Contributor
Author
|
Have you tried this pull request? What is your ROS and ffmpeg version? |
|
Yes, I get that error when patching the code with this pull-request. I was getting the I'm using ROS Kinetic and FFMPEG 2.8.11 with Ubuntu 16.04 |
Contributor
Author
|
It works fine on my side. Here is my FFMPEG info. I also use ROS Kinetic. And here is my output Maybe you can try my fork here |
Member
|
@mescarra any updates? |
|
I did not have time to test your fork. mjpeg with quality 20 is doing the job for me, for the time being. |
jihoonl
approved these changes
Jan 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp8 was tested both on Ubuntu 14.04 and Ubuntu 16.04. It works fine.
vp9 and h264 were tested on Ubuntu 16.04. They can work but the latency was about 10 seconds.
Most of the code were token from pull request #31