Skip to content

Conversation

@jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Apr 16, 2024

Twin PR: meshcat-dev/meshcat#179

Closes: #21314.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Apr 16, 2024
Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least one assigned reviewer, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)


tools/workspace/meshcat/repository.bzl line 13 at r1 (raw file):

        drake/tools/workspace/meshcat/README.md for details.
        """,
        commit = "c0cff8e6990db8e9fb968e6309f9ca16c9dbd3b1",

Working

Needs sha from master

@jwnimmer-tri
Copy link
Collaborator Author

+@SeanCurtis-TRI for both reviews (and meshcat manual test testing), please.

@jwnimmer-tri jwnimmer-tri force-pushed the meshcat-static-html-ktx2-fix branch from 7f9c0a2 to 276fd0f Compare April 16, 2024 18:11
Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform)


tools/workspace/meshcat/repository.bzl line 13 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Working

Needs sha from master

Done

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)

@jwnimmer-tri jwnimmer-tri merged commit 3befa67 into RobotLocomotion:master Apr 16, 2024
@jwnimmer-tri jwnimmer-tri deleted the meshcat-static-html-ktx2-fix branch April 16, 2024 18:44
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Apr 19, 2024
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meshcat StaticHtml fails to load KTX2 textures

2 participants