fix(security): vulnerabilities + remove coveralls (#1333)

Author: benjlevesque

.circleci/config.yml

@@ -133,10 +133,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/request-client.js run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/request-client.js/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/request-client.js/coverage/
   test-data-access:
     docker:
       - *node_image
@@ -152,10 +148,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/data-access run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/data-access/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/data-access/coverage/
   test-data-format:
     docker:
       - *node_image
@@ -171,10 +163,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/data-format run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/data-format/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/data-format/coverage/
   test-transaction-manager:
     docker:
       - *node_image
@@ -190,10 +178,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/transaction-manager run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/transaction-manager/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/transaction-manager/coverage/
   test-ethereum-storage:
     docker:
       - *node_image
@@ -214,10 +198,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/ethereum-storage run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/ethereum-storage/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/ethereum-storage/coverage/
   test-smart-contracts:
     docker:
       - *node_image
@@ -253,10 +233,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/request-logic run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/request-logic/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/request-logic/coverage/
   test-advanced-logic:
     docker:
       - *node_image
@@ -272,10 +248,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/advanced-logic run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/advanced-logic/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/advanced-logic/coverage/
   test-request-node:
     docker:
       - *node_image
@@ -299,10 +271,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/request-node run test --ci'
       - store_test_results:
           path: packages/request-node/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/request-node/coverage/
   test-utils:
     docker:
       - *node_image
@@ -316,10 +284,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/utils run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/utils/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/utils/coverage/
   test-currency:
     docker:
       - *node_image
@@ -332,10 +296,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/currency run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/currency/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/currency/coverage/
   test-epk-signature:
     docker:
       - *node_image
@@ -351,10 +311,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/epk-signature run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/epk-signature/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/epk-signature/coverage/
   test-epk-decryption:
     docker:
       - *node_image
@@ -370,10 +326,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/epk-decryption run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/epk-decryption/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/epk-decryption/coverage/
   test-web3-signature:
     docker:
       - *node_image
@@ -389,10 +341,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/web3-signature run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/web3-signature/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/web3-signature/coverage/
   test-integration-test:
     docker:
       - *node_image
@@ -460,10 +408,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/multi-format run test --ci --maxWorkers=1'
       - store_test_results:
           path: packages/multi-format/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/multi-format/coverage/
   test-payment-detection:
     docker:
       - *node_image
@@ -483,10 +427,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/payment-detection run test --ci'
       - store_test_results:
           path: packages/payment-detection/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/payment-detection/coverage/
   test-payment-processor:
     docker:
       - *node_image
@@ -506,20 +446,6 @@ jobs:
           command: 'yarn workspace @requestnetwork/payment-processor run test --ci'
       - store_test_results:
           path: packages/payment-processor/reports/
-      - persist_to_workspace:
-          root: *working_directory
-          paths:
-            - packages/payment-processor/coverage/
-  publish-coverage:
-    docker:
-      - *node_image
-    working_directory: *working_directory
-    steps:
-      - attach_workspace:
-          at: *working_directory
-      - run:
-          name: 'Publish Coverage'
-          command: 'yarn publish-coverage'
   test-nightly:
     docker:
       - *node_image
@@ -657,29 +583,6 @@ workflows:
           requires:
             - build
 
-      # Publish the code coverage
-      - publish-coverage:
-          requires:
-            - lint
-            - test-advanced-logic
-            - test-currency
-            - test-data-access
-            - test-data-format
-            - test-epk-decryption
-            - test-epk-signature
-            - test-ethereum-storage
-            - test-integration-test
-            - test-multi-format
-            - test-payment-detection
-            - test-payment-processor
-            - test-request-client
-            - test-request-logic
-            - test-request-node
-            - test-smart-contracts
-            - test-transaction-manager
-            - test-utils
-            - test-web3-signature
-
       # Release a next version package everytime we merge to master
       - next-release:
           requires:

README.md

@@ -3,7 +3,6 @@
 ---
 
 [![CircleCI](https://img.shields.io/circleci/project/github/RequestNetwork/requestNetwork/master.svg)](https://circleci.com/gh/RequestNetwork/requestNetwork)
-[![Coverage Status](https://coveralls.io/repos/github/RequestNetwork/requestNetwork/badge.svg?branch=master)](https://coveralls.io/github/RequestNetwork/requestNetwork?branch=master)
 [![Commit Activity](https://img.shields.io/github/commit-activity/m/RequestNetwork/requestNetwork.svg?color=green)](https://github.com/RequestNetwork/requestNetwork/pulse/monthly)
 
 [Request][website-url] is a decentralized network built on top of Ethereum, which allows anyone, anywhere to request a payment. A full description of the protocol may be found in our [whitepaper][whitepaper-url].

jest.config.js

@@ -2,7 +2,6 @@
 module.exports = {
   preset: 'ts-jest',
   testEnvironment: 'node',
-  collectCoverage: true,
   reporters: [
     'default',
     [

package.json

@@ -23,7 +23,6 @@
     "lint-staged": "lint-staged",
     "lerna": "lerna",
     "packageJsonLint": "npmPkgJsonLint ./packages",
-    "publish-coverage": "mkdir -p ./coverage && node scripts/collect.js && nyc merge ./coverage ./coverage/coverage.json && node scripts/remap.js && cat coverage/lcov.info | coveralls",
     "publish-npm": "lerna publish --conventional-commits --exact",
     "publish-manual-prerelease": "lerna publish prerelease --conventional-commits --exact",
     "publish-prerelease": "yarn lerna publish --preid development --skip-git --yes --canary",
@@ -36,21 +35,30 @@
   "devDependencies": {
     "@typescript-eslint/eslint-plugin": "4.18.0",
     "@typescript-eslint/parser": "4.18.0",
-    "coveralls": "3.1.0",
     "eslint": "7.22.0",
     "eslint-config-prettier": "8.1.0",
     "eslint-plugin-import": "2.22.1",
     "eslint-plugin-jsdoc": "32.3.0",
     "eslint-plugin-monorepo": "0.3.2",
     "eslint-plugin-prefer-arrow": "1.2.3",
     "husky": "8.0.1",
-    "lerna": "3.22.1",
+    "lerna": "6.6.2",
     "lint-staged": "10.5.4",
     "npm-package-json-lint": "5.1.0",
-    "nyc": "15.1.0",
     "prettier": "3.0.3",
     "prettier-plugin-solidity": "1.0.0-beta.19",
-    "remap-istanbul": "0.13.0",
     "typescript": "5.1.3"
+  },
+  "resolutions": {
+    "underscore": "^1.12.1",
+    "crypto-js": "^4.2.0",
+    "minimist": "^0.2.4",
+    "semver": "^7.5.4"
+  },
+  "resolutionsDocs": {
+    "underscore": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/14",
+    "crypto-js": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/207",
+    "minimist": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/177",
+    "semver": "https://github.com/RequestNetwork/requestNetwork/security/dependabot/197"
   }
 }

packages/advanced-logic/package.json

@@ -49,7 +49,6 @@
     "@types/node": "18.11.9",
     "jest": "29.5.0",
     "jest-junit": "16.0.0",
-    "nyc": "15.1.0",
     "shx": "0.3.2",
     "ts-jest": "29.1.0",
     "ts-node": "10.9.1",

packages/data-access/package.json

@@ -49,7 +49,6 @@
     "@types/node": "18.11.9",
     "jest": "29.5.0",
     "jest-junit": "16.0.0",
-    "nyc": "15.1.0",
     "shx": "0.3.2",
     "source-map-support": "0.5.19",
     "ts-jest": "29.1.0",

packages/data-format/package.json

@@ -47,7 +47,6 @@
   "devDependencies": {
     "@types/node": "18.11.9",
     "jest-junit": "16.0.0",
-    "nyc": "15.1.0",
     "rimraf": "3.0.2",
     "shx": "0.3.2",
     "ts-node": "10.9.1",

packages/epk-decryption/package.json

@@ -54,7 +54,6 @@
     "jest": "29.5.0",
     "jest-junit": "16.0.0",
     "npm-run-all": "4.1.5",
-    "nyc": "15.1.0",
     "shx": "0.3.2",
     "source-map-support": "0.5.19",
     "stream-browserify": "3.0.0",

packages/epk-signature/package.json

@@ -53,7 +53,6 @@
     "jest": "29.5.0",
     "jest-junit": "16.0.0",
     "npm-run-all": "4.1.5",
-    "nyc": "15.1.0",
     "shx": "0.3.2",
     "source-map-support": "0.5.19",
     "stream-browserify": "3.0.0",

packages/ethereum-storage/package.json

@@ -58,7 +58,6 @@
     "jest": "29.5.0",
     "jest-junit": "16.0.0",
     "msw": "2.0.6",
-    "nyc": "15.1.0",
     "shx": "0.3.2",
     "solium": "1.2.5",
     "source-map-support": "0.5.19",