refactor(retryWhen/repeatWhen): Refactor "fooling" the _unsubscribe method (#3295)

Author: martinsik

src/internal/operators/repeatWhen.ts

@@ -100,14 +100,12 @@ class RepeatWhenSubscriber<T, R> extends OuterSubscriber<T, R> {
   }
 
   protected _unsubscribeAndRecycle(): Subscriber<T> {
-    const { notifications, retries, retriesSubscription } = this;
-    this.notifications = null;
-    this.retries = null;
-    this.retriesSubscription = null;
+    const { _unsubscribe } = this;
+
+    this._unsubscribe = null;
     super._unsubscribeAndRecycle();
-    this.notifications = notifications;
-    this.retries = retries;
-    this.retriesSubscription = retriesSubscription;
+    this._unsubscribe = _unsubscribe;
+
     return this;
   }
 

src/internal/operators/retryWhen.ts

@@ -102,16 +102,11 @@ class RetryWhenSubscriber<T, R> extends OuterSubscriber<T, R> {
   notifyNext(outerValue: T, innerValue: R,
              outerIndex: number, innerIndex: number,
              innerSub: InnerSubscriber<T, R>): void {
-    const { errors, retries, retriesSubscription } = this;
-    this.errors = null;
-    this.retries = null;
-    this.retriesSubscription = null;
+    const { _unsubscribe } = this;
 
+    this._unsubscribe = null;
     this._unsubscribeAndRecycle();
-
-    this.errors = errors;
-    this.retries = retries;
-    this.retriesSubscription = retriesSubscription;
+    this._unsubscribe = _unsubscribe;
 
     this.source.subscribe(this);
   }