Merge pull request #2363 from Podlas29/static-merge-with-one-observable-input

fix(merge): return Observable when called with single lowerCaseO

Author: jayphelps

spec/helpers/test-helper.ts

@@ -8,11 +8,10 @@ import {$$iterator} from '../../dist/cjs/symbol/iterator';
 import $$symbolObservable from 'symbol-observable';
 
 export function lowerCaseO<T>(...args): Rx.Observable<T> {
-  const values = [].slice.apply(arguments);
 
   const o = {
     subscribe: function (observer) {
-      values.forEach(function (v) {
+      args.forEach(function (v) {
         observer.next(v);
       });
       observer.complete();

spec/observables/merge-spec.ts

@@ -1,5 +1,6 @@
 import {expect} from 'chai';
 import * as Rx from '../../dist/cjs/Rx';
+import {lowerCaseO} from '../helpers/test-helper';
 import marbleTestingSignature = require('../helpers/marble-testing'); // tslint:disable-line:no-require-imports
 
 declare const hot: typeof marbleTestingSignature.hot;
@@ -210,6 +211,36 @@ describe('Observable.merge(...observables)', () => {
     expectSubscriptions(e1.subscriptions).toBe(e1subs);
     expectSubscriptions(e2.subscriptions).toBe(e2subs);
   });
+
+  it('should merge single lowerCaseO into RxJS Observable', () => {
+    const e1 = lowerCaseO('a', 'b', 'c');
+
+    const result = Observable.merge(e1);
+
+    expect(result).to.be.instanceof(Observable);
+    expectObservable(result).toBe('(abc|)');
+  });
+
+  it('should merge two lowerCaseO into RxJS Observable', () => {
+    const e1 = lowerCaseO('a', 'b', 'c');
+    const e2 = lowerCaseO('d', 'e', 'f');
+
+    const result = Observable.merge(e1, e2);
+
+    expect(result).to.be.instanceof(Observable);
+    expectObservable(result).toBe('(abcdef|)');
+  });
+});
+
+describe('Observable.merge(...observables, Scheduler)', () => {
+  it('should merge single lowerCaseO into RxJS Observable', () => {
+    const e1 = lowerCaseO('a', 'b', 'c');
+
+    const result = Observable.merge(e1, rxTestScheduler);
+
+    expect(result).to.be.instanceof(Observable);
+    expectObservable(result).toBe('(abc|)');
+  });
 });
 
 describe('Observable.merge(...observables, Scheduler, number)', () => {

src/operator/merge.ts

@@ -160,7 +160,7 @@ export function mergeStatic<T, R>(...observables: Array<ObservableInput<any> | I
     concurrent = <number>observables.pop();
   }
 
-  if (scheduler === null && observables.length === 1) {
+  if (scheduler === null && observables.length === 1 && observables[0] instanceof Observable) {
     return <Observable<R>>observables[0];
   }