fix(rxjs): no longer requires dom lib#3566
Conversation
Adds interfaces to cover what is used from DOM in `fromEvent` so that types are carried through, but `dom` lib isn not required by default even if you are not using `fromEvent` fixes: ReactiveX#3558
| let unsubscribe: () => void; | ||
| if (isNodeList(sourceObj) || isHTMLCollection(sourceObj)) { | ||
| for (let i = 0, len = sourceObj.length; i < len; i++) { | ||
| if (sourceObj && (sourceObj as any).length) { |
There was a problem hiding this comment.
You can use isArrayLike here, right? https://github.com/ReactiveX/rxjs/blob/master/src/internal/util/isArrayLike.ts
|
Hey, this has some major issues when you want to do when subscribing. |
|
@specialkk Thanks for pointing out a problem. Could you please create an issue and, from it, reference this PR? I'm not a maintainer of this particular repo, but I think I speak for all maintainers in saying that it's preferable to have new issues opened, than to have comments made on closed issues or merged PRs. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adds interfaces to cover what is used from DOM in
fromEventso that types are carried through, butdomlib isn not required by default even if you are not usingfromEventfixes: #3558