feat(umd): UMD now mirrors export schema for ESM and CJS#3426
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Mar 13, 2018
Merged
feat(umd): UMD now mirrors export schema for ESM and CJS#3426benlesh merged 1 commit intoReactiveX:masterfrom
benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
IgorMinar
approved these changes
Mar 13, 2018
Contributor
IgorMinar
left a comment
IgorMinar
left a comment
There was a problem hiding this comment.
consider the filename change. the rest looks good
.make-packages.js
Outdated
| addLicenseTextToFile(license, UMD_PKG + 'Rx.min.js'); | ||
| addLicenseToFile('LICENSE.txt', UMD_PKG + 'Rx.js'); | ||
| addLicenseTextToFile(license, UMD_PKG + 'Rx.min.js'); | ||
| addLicenseToFile('LICENSE.txt', UMD_PKG + 'rx.js'); |
Contributor
There was a problem hiding this comment.
I suggest that all these files are called rxjs.*, i.e. rxjs.umd.js and rxjs.umd.min.js
Contributor
There was a problem hiding this comment.
this is just to be consistent about the naming across all the namespaces.
kwonoj
approved these changes
Mar 13, 2018
Member
kwonoj
left a comment
kwonoj
left a comment
There was a problem hiding this comment.
lol danger for size comparison broken by uppercase to lowercase file name conversion. looks ok otherwise.
benlesh
force-pushed
the
umd-work
branch
2 times, most recently
from
f9343c3 to
ad4a8b5
Compare
Member
Author
|
@kwonoj I"m just going to disable that part of the script for now. |
For example, if you want to do the same thing as but using the global file, you would use , If you wanted to do , that will be available at . Thus making the import/access points more predictable between the UMD and the ESM and CJS versions.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, if you want to do the same thing as but using the global file, you would use , If you wanted to do , that will be available at . Thus making the import/access points more predictable between the UMD and the ESM and CJS versions.