fix(concat): return Observable when called with single lowerCaseO#2387
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Feb 21, 2017
mpodlasin:static-concat-with-one-observable-input
Merged
fix(concat): return Observable when called with single lowerCaseO#2387benlesh merged 1 commit intoReactiveX:masterfrom mpodlasin:static-concat-with-one-observable-input
benlesh merged 1 commit intoReactiveX:masterfrom
mpodlasin:static-concat-with-one-observable-input
Conversation
When static concat is called with single lower case observable, adapt it to RxJS Observable, so that operator would always return an Observable instance.
kwonoj
approved these changes
Feb 18, 2017
benlesh
approved these changes
Feb 20, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When static
concatis passed single lower case observable, it returns that lower case observable, instead of adapting it to RxJS Observable.Related issue:
#2363 <- we had exactly the same issue with merge