fix(Object.assign): stop polyfilling Object assign#2080
Merged
jayphelps merged 1 commit intoReactiveX:masterfrom Nov 4, 2016
benlesh:assign
Merged
fix(Object.assign): stop polyfilling Object assign#2080jayphelps merged 1 commit intoReactiveX:masterfrom benlesh:assign
jayphelps merged 1 commit intoReactiveX:masterfrom
benlesh:assign
Conversation
RxJS should not be responsible for polyfilling `Object.assign`. This should also increase code coverage around the alternate method used for assign BREAKING CHANGE: RxJS will no longer polyfill `Object.assign`. It does not require `Object.assign` to function, however, your code may be inadvertently relying on this polyfill.
Member
|
LGTM |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if exists):
RxJS should not be responsible for polyfilling
Object.assign.This should also increase code coverage around the alternate method used for assign
BREAKING CHANGE: RxJS will no longer polyfill
Object.assign. It doesnot require
Object.assignto function, however, your code may beinadvertently relying on this polyfill.