fix(IteratorObservable): clarify the return type of IteratorObservable.create()#2070
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Nov 4, 2016
Conversation
tetsuharuohzeki
force-pushed
the
clarify-IteratorObservable-create
branch
from
bb474c6 to
62e604c
Compare
Contributor
Author
|
updated the commit message |
tetsuharuohzeki
force-pushed
the
clarify-IteratorObservable-create
branch
from
62e604c to
c978d27
Compare
…e.create()
BREAKING CHANGE - `IteratorObservable.create<T>()` now returns correctly
`Obsevable<T>` with supplied type parameter `T`. This fixes the previous
implmentations which always returns `Obsevable<{}>`.
tetsuharuohzeki
force-pushed
the
clarify-IteratorObservable-create
branch
from
48908d1 to
602bcd8
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
IteratorObservable.create<number>()with specifying type parameter, the return type of it wasIteratorObservable<{}>. This pull request fix this.