fix(ReplaySubject): observer now subscribed prior to running subscrip…#2046
Merged
jayphelps merged 4 commits intoReactiveX:masterfrom Oct 24, 2016
benlesh:fixReplaySubject
Merged
fix(ReplaySubject): observer now subscribed prior to running subscrip…#2046jayphelps merged 4 commits intoReactiveX:masterfrom benlesh:fixReplaySubject
jayphelps merged 4 commits intoReactiveX:masterfrom
benlesh:fixReplaySubject
Conversation
…tion function Removed reliance on inherited `_subscribe` method from `Subject`. ReplaySubject has different behaviors during subscription for notifying new subscribers after a completion or error. After moving the `super._subscribe` call before the notification from saved `_events`, it was apparent that the inherited behavior from `Subject` was stopping the subscriber before it could be notified properly. fixes #2044
Member
|
LGTM |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion function
Removed reliance on inherited
_subscribemethod fromSubject. ReplaySubject has different behaviors during subscription for notifying new subscribers after a completion or error. After moving thesuper._subscribecall before the notification from saved_events, it was apparent that the inherited behavior fromSubjectwas stopping the subscriber before it could be notified properly.fixes #2044