feat(compat): set up correct imports & get build working for rxjs-comapt

Author: jasonaden

.gitignore

@@ -12,6 +12,7 @@ typings/
 
 # Generated
 dist/
+dist-compat/
 tmp/
 coverage/
 img/

.make-compat-package.js

@@ -0,0 +1,53 @@
+"use strict";
+
+let pkg = require('./compat/package.json');
+let fs = require('fs-extra');
+let mkdirp = require('mkdirp');
+let path = require('path');
+let klawSync = require('klaw-sync');
+let licenseTool = require('./tools/add-license-to-file');
+let addLicenseToFile = licenseTool.addLicenseToFile;
+let addLicenseTextToFile = licenseTool.addLicenseTextToFile;
+
+const ROOT = 'dist-compat/';
+const CJS_ROOT = ROOT + 'cjs/compat/';
+const ESM5_ROOT = ROOT + 'esm5/compat/';
+const ESM2015_ROOT = ROOT + 'esm2015/compat/';
+const TYPE_ROOT = ROOT + 'typings/compat/';
+const PKG_ROOT = ROOT + 'package/';
+const CJS_PKG = PKG_ROOT + '';
+const ESM5_PKG = PKG_ROOT + '_esm5/';
+const ESM2015_PKG = PKG_ROOT + '_esm2015/';
+const UMD_PKG = PKG_ROOT + 'bundles/';
+const TYPE_PKG = PKG_ROOT;
+
+// License info for minified files
+let licenseUrl = 'https://github.com/ReactiveX/RxJS/blob/master/LICENSE.txt';
+let license = 'Apache License 2.0 ' + licenseUrl;
+
+// Recreate the distribution folder
+fs.removeSync(PKG_ROOT);
+mkdirp.sync(PKG_ROOT);
+
+// Copy over the sources
+fs.copySync(TYPE_ROOT, TYPE_PKG);
+copySources(CJS_ROOT, CJS_PKG);
+copySources(ESM5_ROOT, ESM5_PKG, true);
+copySources(ESM2015_ROOT, ESM2015_PKG, true);
+
+fs.copySync('compat/package.json', PKG_ROOT + '/package.json');
+
+function copySources(rootDir, packageDir, ignoreMissing) {
+  // If we are ignoring missing directories, early return when source doesn't exist
+  if (!fs.existsSync(rootDir)) {
+    if (ignoreMissing) {
+      return;
+    } else {
+      throw "Source root dir does not exist!";
+    }
+  }
+  // Copy over the CommonJS files
+  fs.copySync(rootDir, packageDir);
+  fs.copySync('./LICENSE.txt', packageDir + 'LICENSE.txt');
+  fs.copySync('./compat/README.md', packageDir + 'README.md');
+}

compat/README.md

@@ -0,0 +1,15 @@
+# RxJS Compatibility Package
+
+This package is required to get backwards compatibility with RxJS pervious to version 6. It contains the imports to add operators to `Observable.prototype` and creation methods to `Observable`. This is what allows, for instance, dot-chaining:
+
+```
+Observable.interval(1)
+  .map(i => i * i)
+```
+
+vs
+
+```
+Observable.interval(1)
+  .pipe(map(i => i * i))
+```

compat/index.ts compat/Rx.tscompat/index.ts renamed to compat/Rx.ts

@@ -157,23 +157,21 @@ export {
 
 export {TestScheduler} from 'rxjs/testing';
 
-export {Operator} from 'rxjs/internal/Operator';
-export {Subscriber} from 'rxjs/internal/Subscriber';
-export {AsyncSubject} from 'rxjs/internal/AsyncSubject';
-export {ConnectableObservable} from 'rxjs/internal/observable/ConnectableObservable';
-export {TimeoutError} from 'rxjs/internal/util/TimeoutError';
-export {TimeInterval} from 'rxjs/internal/patching/operator/timeInterval';
-export {Timestamp} from 'rxjs/internal/operators/timestamp';
-export {VirtualTimeScheduler} from 'rxjs/internal/scheduler/VirtualTimeScheduler';
-export {AjaxRequest, AjaxResponse, AjaxError, AjaxTimeoutError} from 'rxjs/internal/observable/dom/AjaxObservable';
+export { Operator } from 'rxjs/internal/Operator';
+export { Subscriber } from 'rxjs/internal/Subscriber';
+export { AsyncSubject } from 'rxjs/internal/AsyncSubject';
+export { ConnectableObservable } from 'rxjs/internal/observable/ConnectableObservable';
+export { TimeoutError } from 'rxjs/internal/util/TimeoutError';
+export { TimeInterval } from 'rxjs/internal/patching/operator/timeInterval';
+export { Timestamp } from 'rxjs/internal/operators/timestamp';
+export { VirtualTimeScheduler } from 'rxjs/internal/scheduler/VirtualTimeScheduler';
+export { AjaxRequest, AjaxResponse, AjaxError, AjaxTimeoutError } from 'rxjs/internal/observable/dom/AjaxObservable';
+import { AsapScheduler } from 'rxjs/internal/scheduler/AsapScheduler';
+import { AsyncScheduler } from 'rxjs/internal/scheduler/AsyncScheduler';
+import { QueueScheduler } from 'rxjs/internal/scheduler/QueueScheduler';
+import { AnimationFrameScheduler } from 'rxjs/internal/scheduler/AnimationFrameScheduler';
 
-import {
-  asapScheduler as asap,
-  asyncScheduler as async,
-  queueScheduler as queue,
-  animationFrameScheduler as animationFrame,
-
-} from 'rxjs';
+import { asapScheduler, asyncScheduler, queueScheduler, animationFrameScheduler } from 'rxjs';
 
 import { rxSubscriber } from 'rxjs/internal/symbol/rxSubscriber';
 import { iterator } from 'rxjs/internal/symbol/iterator';
@@ -199,10 +197,10 @@ export const operators = _operators;
  * Use this for synchronizing with the platform's painting
  */
 let Scheduler = {
-  asap,
-  queue,
-  animationFrame,
-  async
+  asap: asapScheduler,
+  queue: queueScheduler,
+  animationFrame: animationFrameScheduler,
+  async: asyncScheduler
 };
 
 /**

compat/add/observable/bindCallback.ts

@@ -1,9 +1,8 @@
-import { Observable } from '../../internal/Observable';
-import { bindCallback as staticBindCallback } from '../../internal/observable/bindCallback';
+import { Observable, bindCallback as staticBindCallback } from 'rxjs';
 
 Observable.bindCallback = staticBindCallback;
 
-declare module '../../internal/Observable' {
+declare module 'rxjs/internal/Observable' {
   namespace Observable {
     export let bindCallback: typeof staticBindCallback;
   }

compat/add/observable/bindNodeCallback.ts

@@ -1,9 +1,8 @@
-import { Observable } from '../../internal/Observable';
-import { bindNodeCallback as staticBindNodeCallback } from '../../internal/observable/bindNodeCallback';
+import { Observable, bindNodeCallback as staticBindNodeCallback } from 'rxjs';
 
 Observable.bindNodeCallback = staticBindNodeCallback;
 
-declare module '../../internal/Observable' {
+declare module 'rxjs/internal/Observable' {
   namespace Observable {
     export let bindNodeCallback: typeof staticBindNodeCallback;
   }

compat/add/observable/combineLatest.ts

@@ -1,9 +1,8 @@
-import { Observable } from '../../internal/Observable';
-import { combineLatest as combineLatestStatic } from '../../internal/observable/combineLatest';
+import { Observable, combineLatest as combineLatestStatic } from 'rxjs';
 
 Observable.combineLatest = combineLatestStatic;
 
-declare module '../../internal/Observable' {
+declare module 'rxjs/internal/Observable' {
   namespace Observable {
     export let combineLatest: typeof combineLatestStatic;
   }

compat/add/observable/concat.ts

@@ -1,9 +1,8 @@
-import { Observable } from '../../internal/Observable';
-import { concat as concatStatic } from '../../internal/observable/concat';
+import { Observable, concat as concatStatic } from 'rxjs';
 
 Observable.concat = concatStatic;
 
-declare module '../../internal/Observable' {
+declare module 'rxjs/internal/Observable' {
   namespace Observable {
     export let concat: typeof concatStatic;
   }

compat/add/observable/defer.ts

@@ -1,9 +1,9 @@
-import { Observable } from '../../internal/Observable';
-import { defer as staticDefer } from '../../internal/observable/defer';
+import { Observable } from 'rxjs';
+import { defer as staticDefer } from 'rxjs/observable/defer';
 
 Observable.defer = staticDefer;
 
-declare module '../../internal/Observable' {
+declare module 'rxjs/internal/Observable' {
   namespace Observable {
     export let defer: typeof staticDefer;
   }

compat/add/observable/dom/ajax.ts

@@ -1,10 +1,10 @@
-import { Observable } from '../../../internal/Observable';
-import { ajax as staticAjax } from '../../../internal/observable/dom/ajax';
-import { AjaxCreationMethod } from '../../../internal/observable/dom/AjaxObservable';
+import { Observable } from 'rxjs';
+import { ajax as staticAjax } from 'rxjs/ajax';
+import { AjaxCreationMethod } from 'rxjs/internal/observable/dom/AjaxObservable';
 
 Observable.ajax = staticAjax;
 
-declare module '../../../internal/Observable' {
+declare module 'rxjs/internal/Observable' {
   namespace Observable {
     export let ajax: AjaxCreationMethod;
   }