boards/esp32s3-usb-otg: enable SDMMC peripheral #21471
Conversation
github-actions
bot
added
Area: doc
gschorcht
added
Type: enhancement
gschorcht
added
CI: ready for build
boards/esp32s3-usb-otg/doc.txt
Outdated
| @note | ||
| SPI_DEV(1) is only configured if the `sdcard_spi` module is explicitly used to | ||
| access the SD card in SPI mode. Otherwise, the SDMMC host is configured and | ||
| used by the `periph_sdmmc` module to access the SD card (default). That is, | ||
| add module `sdcard_spi` to the make variable `USEMODULE` to use the SD Card | ||
| in SPI mode. |
There was a problem hiding this comment.
| @note | |
| SPI_DEV(1) is only configured if the `sdcard_spi` module is explicitly used to | |
| access the SD card in SPI mode. Otherwise, the SDMMC host is configured and | |
| used by the `periph_sdmmc` module to access the SD card (default). That is, | |
| add module `sdcard_spi` to the make variable `USEMODULE` to use the SD Card | |
| in SPI mode. | |
| @note | |
| SPI_DEV(1) is only configured if the `sdcard_spi` module is explicitly added to the | |
| `USEMODULE` in the application's Makefile to access the SD card in SPI mode. | |
| By default, the SDMMC host is configured and used by the `periph_sdmmc` | |
| module to access the SD card. |
The last sentence is a bit redundant IMO.
| ifeq (,$(filter sdcard_spi,$(USEMODULE))) | ||
| # use mtd_sdmmc_default if sdcard_spi isn't explicitly enabled | ||
| USEMODULE += mtd_sdmmc_default | ||
| endif |
There was a problem hiding this comment.
Wouldn't this need an "else" case to include mtd_sdcard_default?
There was a problem hiding this comment.
I had the else branch in the initial commit d1774e6, but I had to remove it with commit 9960a62 because the compilation of tests/pkg/fatfs failed because both mtd_sdmmc_default and mtd_sdcard_default were enabled for this application.
BOARD=esp32s3-usb-otg make -j4 -C tests/pkg/fatfs info-modules
...
mtd
mtd_sdcard
mtd_sdcard_default
mtd_sdmmc
mtd_sdmmc_default
The reason seems to be that the Makefile of this application enables mtd_sdcard unconditionally. We should probably change this Makefile in near future. But for this PR, it works in that way and it is defined in same way for the esp32-wrover-kit board.
There was a problem hiding this comment.
The same problem is given for tests/pkg/fatfs_vfs.
There was a problem hiding this comment.
Okay, I see. I'd feel comfortable merging this intermediate solution if you opened a second PR or issue, so that we don't lose track of it and possibly introduce unforeseen behavior.
gschorcht
force-pushed
the
boards/esp32-usb-otg_enable_sdmmc
branch
from
d1481be to
e770299
Compare
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
Again, I have no hardware to test this, but the changes look reasonable as well.
I'm sorry that this took such a tangent with the other PR, which was more work than anticipated 😅
But nevertheless, thank you for your persistence.
You can squash the fixups and hit merge once everything is ready.
I have the hardware and have tested it extensively 😉 |
gschorcht
force-pushed
the
boards/esp32-usb-otg_enable_sdmmc
branch
from
e770299 to
1842b2f
Compare
4 participants
Contribution description
This PR enables the
periph_sdmmcfeature for theesp32s3-usb-otgboard to use the SDMMC Host to access the SD Card instead of using the SD Card in SPI mode.Testing procedure
should still work.
Issues/PRs references
Depends on PR #21478