sys/psa_crypto: Adding aead aes ccm

[Lukas-Luger]

Contribution description

This PR adds AES CCM as the first Authenticated encryption with associated data algorithm to the PSA Certified Crypto API implementation of RIOT.

It comes with three backends:

Cifra

• supports all three key sizes (128, 192, 256)

Tinycrypt

• only supports 128 bit key size
• nonce size is limited to 13 Bytes

Cryptocell 310

• only supports 128 bit key size

Testing procedure

A test is provided in tests/sys/psa_crypto_aead.
Note that the test will fail on tinycrypt because of invalid nonce size.

Issues/PRs references

This is highly inspired by #18547.

[riot-ci]

Murdock results

✔️ PASSED

406d6dc pkg/driver_cryptocell_310: add psa_crypto aes ccm

Success	Failures	Total	Runtime
10382	0	10383	15m:06s

Artifacts

• Documentation preview

[mguetschow]

Thanks for doing this! Here's a first round of review. Haven't tested it locally yet.

[mguetschow]

Oh, and something seems to be off in your automatic backend selection:

-- running on worker alien thread 1, build number 13791.
make: Entering directory '/tmp/dwq.0.49495055948356803/0b95bb80d67d834a634a4edd6938ca1d/tests/sys/psa_crypto_aead'
 You are going to use the PSA Crypto module, which is only partly implemented and not yet thouroughly tested.\n Please do not use this module in production, as it may introduce security issues!
/tmp/dwq.0.49495055948356803/0b95bb80d67d834a634a4edd6938ca1d/sys/psa_crypto/Makefile.include:111: *** "One (and only one) backend should be selected for psa_aead_aes_128_ccm".  Stop.
make: Leaving directory '/tmp/dwq.0.49495055948356803/0b95bb80d67d834a634a4edd6938ca1d/tests/sys/psa_crypto_aead'
make: Entering directory '/tmp/dwq.0.49495055948356803/0b95bb80d67d834a634a4edd6938ca1d/tests/sys/psa_crypto_aead'
 You are going to use the PSA Crypto module, which is only partly implemented and not yet thouroughly tested.\n Please do not use this module in production, as it may introduce security issues!
/tmp/dwq.0.49495055948356803/0b95bb80d67d834a634a4edd6938ca1d/sys/psa_crypto/Makefile.include:111: *** "One (and only one) backend should be selected for psa_aead_aes_128_ccm".  Stop.
make: Leaving directory '/tmp/dwq.0.49495055948356803/0b95bb80d67d834a634a4edd6938ca1d/tests/sys/psa_crypto_aead'
cat: /tmp/dwq.0.49495055948356803/0b95bb80d67d834a634a4edd6938ca1d/build/test-input-hash.sha1: No such file or directory

[mguetschow]

Thanks for this! Feel free to squash directly after adding the missing documentation.

[Lukas-Luger]

No Problem. Everything should be ready now ;)

[mguetschow]

Sorry, one last nit, found while trying to compile with

diff --git a/tests/sys/psa_crypto_aead/Makefile b/tests/sys/psa_crypto_aead/Makefile
index e0fdc67078..5d8f3615e1 100644
--- a/tests/sys/psa_crypto_aead/Makefile
+++ b/tests/sys/psa_crypto_aead/Makefile
@@ -6,6 +6,8 @@ USEMODULE += psa_crypto
 
 USEMODULE += psa_aead
 USEMODULE += psa_aead_aes_128_ccm
+USEMODULE += psa_aead_aes_128_ccm_custom_backend
+USEMODULE += psa_aead_aes_128_ccm_backend_tinycrypt
 
 CFLAGS += -DCONFIG_PSA_SINGLE_KEY_COUNT=2

Also, would you mind updating your commit messages and remove all the fixup commit messages? I can show you how to, if needed.

[Lukas-Luger]

Should be all done now. Sorry for the delay

[mguetschow]

Thanks!

[crasbe]

You'll have to add a Makefile.ci to the tests/sys/psa_crypto_aead with the following content:

BOARD_INSUFFICIENT_MEMORY := \
    nucleo-l011k4 \
    samd10-xmini \
    stm32f030f4-demo \
    #