boards: add support for ESP32-S3 WT32 SC01 Plus board #19917

gschorcht · 2023-09-07T10:55:28Z

Contribution description

This PR provides support for the Wireless Tag WT32-SC01 Plus with ESP32-S3 board. The board has the following main features:

ESP32-S3 SoC
16 MB Flash
2 MB QSPI RAM
3.5" LCD Display 480 x 320 with ST7796UI
Capacitive Touch Panel with FT6336U
SD Card SPI mode
USB Type-C

Please note: The ST7796UI display uses the MCU8080 8-bit parallel interface which require the changes in PR #19915.

Testing procedure

tests/drivers/st77xx should work on top of PR drivers/lcd: support MCU 8080 8-bit parallel mode #19915.
```
BOARD=esp32s3-wt32-sc01-plus make -j8 -C tests/drivers/st77xx flash
```

tests/drivers/ft5x06 should work with stdio_uart and the debugging tool.

USEMODULE=stdio_uart BOARD=esp32s3-wt32-sc01-plus make -j8 -C tests/drivers/ft5x06/ flash term

main(): This is RIOT! (Version: 2023.10-devel-245-g55bd7-boards/esp32s3-wt32-sc01-plus)
FT5x06 test application

+------------Initializing------------+
Initialization successful
1 touch detected
Touch 1 - X: 177, Y:96
Touch 1 - X: 177, Y:96
Touch 1 - X: 177, Y:96
Touch 1 - X: 177, Y:97
Touch 1 - X: 178, Y:99
Touch 1 - X: 180, Y:102
Touch 1 - X: 184, Y:106
Touch 1 - X: 190, Y:110
Touch 1 - X: 197, Y:116
Touch 1 - X: 204, Y:122
Released!

Issues/PRs references

riot-ci · 2023-09-07T11:04:44Z

Murdock results

✔️ PASSED

65d937c drivers/st77xx: fix init for ST7796

Success	Failures	Total	Runtime
7937	0	7937	19m:45s

Artifacts

Documentation preview

19914: boards: complete SD Card MTD definition for several bords r=benpicco a=gschorcht ### Contribution description This PR completes the MTD definition for the following boards: - `seeedstudio-gd32` - `sipeed-longan-nano` including `sipeed-longan-nano-tft` - `waveshare-nrf52840-eval-kit` - ESP32x boards that have an SPI SD Card interface and use `mtd_sdcard_default` ### Testing procedure Green CI ### Issues/PRs references#19465 Prerequisite for PR #19465 19915: drivers/lcd: support MCU 8080 8-bit parallel mode r=benpicco a=gschorcht ### Contribution description LCD driver ICs usually support - SPI serial mode, - MCU 8080 8-bit parallel mode and - MCU 8080 16-bit parallel mode. This PR extends the LCD display driver API to support the MCU 8080 8-/16-bit parallel modes and implements a GPIO-driven MCU 8080 8-bit parallel mode. The following features are already working locally and will be provided as follow-on PRs for which this PR is a prerequisite. - GPIO-driven bit-banging implementation of the 16-bit mode of the MCU 8080 parallel interface - Enabling the display on `stm32f723e-disco` and `stm32l496g-disco` using the feature above - Definition of a low-level API for the parallel modes using the LCD controller of the MCU - Using FMC for the display on `stm32f723e-disco` and `stm32l496g-disco` - Using LCD controller for the display of `esp32-wt32-sc01-plus` (PR #19917) ### Testing procedure The PR can be tested with PR #19917 on top of this PR. ``` BOARD=esp32s3-wt32-sc01-plus make -j8 -C tests/drivers/st77xx flash ``` The following video shows the test. **Please note** The test is pretty slow because the display has 480 x 320 pixels and the MCU 8080 8-bit parallel interface is realized by a GPIO-driven bit-banging implementation where each GPIO of the data bus is set separately. A follow-up PR will use the ESP32-S3 LCD controller and DMA for this board. This PR just defines the extension of the driver by the parallel interface and provides the bit-banging implementation for MCUs that don't have a LCD controller on chip. https://github.com/RIOT-OS/RIOT/assets/31932013/c1e3e3d7-05d9-4ca5-8fff-9a5eaca50fba ### Issues/PRs references 19919: drivers/st77xx: introduce rotation defines r=benpicco a=gschorcht ### Contribution description The PR introduces counterclockwise rotations for the definition of parameter `ST77XX_PARAM_ROTATION`. It is more intuitive and universal to use `ST77XX_ROTATION_{0,90,180,270}` instead of `ST77XX_ROTATION_{ST77XX_ROTATION_{VERT,VERT_FLIP,HORZ,HORZ_FLIP}`, especially because the orientation of the display may vary with respect to the orientation of the board. ### Testing procedure `tests/drivers/st77xx` should still work, for example: ``` BOARD=adafruit-pybadge make -C tests/drivers/st77xx flash ``` ``` BOARD=esp32s3-usb-otg make -j8 -C tests/drivers/st77xx flash ``` ### Issues/PRs references 19931: boards: fix documentation for GD32V boards and doxygen 1.9.4 r=benpicco a=gschorcht ### Contribution description This PR fixes some small problems in documentation of `sipeed-longan-nano`, `sipeed-longan-nano-tft` and `seeedstudio-gd32` for doxygen 1.9.4 that is used on `doc.riot-os.org`. Doxygen version 1.9.4 doesn't like anymore - single double quotes as symbol for the inches unit in the text - line breaks in `[]()` to avoid exhausting the 100 characters per line. See https://doc.riot-os.org/group__boards__sipeed__longan__nano.html for example. Doxygen 1.9.1 which is part of `riot-docker` container didn't have theses problems 😟 ### Testing procedure Documentation should be fixed. ### Issues/PRs references 19935: boards/nucleo64: fix SPI Arduino mapping for most boards r=benpicco a=maribu ### Contribution description Before, the Arduino SPI mapping for all Nucleo-64 boards was incorrect. With this, the situation improves to the following: - [x] nucleo-f030r8 - [ ] nucleo-f070rb - No SPI buses provided. - [x] nucleo-f072rb - [x] nucleo-f091rc - [x] nucleo-f103rb - [ ] nucleo-f302r8 - No SPI bus at D11, D12, D13 provided - [x] nucleo-f303re - [x] nucleo-f334r8 - [x] nucleo-f401re - [x] nucleo-f410rb - [x] nucleo-f411re - [x] nucleo-f446re - [x] nucleo-g070rb - [x] nucleo-g071rb - [x] nucleo-g431rb - [x] nucleo-g474re - [x] nucleo-l053r8 - [x] nucleo-l073rz - [x] nucleo-l152re - No SPI bus at D11, D12, D13 provided - [x] nucleo-l452re - [x] nucleo-l476rg - [x] nucleo-wl55jc The remaining offenders still need to be fixed, but that is better done one PR at a time. ### Testing procedure - Check if the SPI device provided in the given `boards/<BOARD_NAME>/incude/periph_conf.h` is indeed `SPI_DEV(0)`, or in `periph_conf.h` the correct SPI dev is found - this should be fine for all boards above, except for the unchecked ones or: - run #19932: The SPI test should pass now ### Issues/PRs references Bug found in #19932 (comment) Co-authored-by: Gunar Schorcht <[email protected]> Co-authored-by: Marian Buschsieweke <[email protected]>

19914: boards: complete SD Card MTD definition for several bords r=benpicco a=gschorcht ### Contribution description This PR completes the MTD definition for the following boards: - `seeedstudio-gd32` - `sipeed-longan-nano` including `sipeed-longan-nano-tft` - `waveshare-nrf52840-eval-kit` - ESP32x boards that have an SPI SD Card interface and use `mtd_sdcard_default` ### Testing procedure Green CI ### Issues/PRs references#19465 Prerequisite for PR #19465 19915: drivers/lcd: support MCU 8080 8-bit parallel mode r=benpicco a=gschorcht ### Contribution description LCD driver ICs usually support - SPI serial mode, - MCU 8080 8-bit parallel mode and - MCU 8080 16-bit parallel mode. This PR extends the LCD display driver API to support the MCU 8080 8-/16-bit parallel modes and implements a GPIO-driven MCU 8080 8-bit parallel mode. The following features are already working locally and will be provided as follow-on PRs for which this PR is a prerequisite. - GPIO-driven bit-banging implementation of the 16-bit mode of the MCU 8080 parallel interface - Enabling the display on `stm32f723e-disco` and `stm32l496g-disco` using the feature above - Definition of a low-level API for the parallel modes using the LCD controller of the MCU - Using FMC for the display on `stm32f723e-disco` and `stm32l496g-disco` - Using LCD controller for the display of `esp32-wt32-sc01-plus` (PR #19917) ### Testing procedure The PR can be tested with PR #19917 on top of this PR. ``` BOARD=esp32s3-wt32-sc01-plus make -j8 -C tests/drivers/st77xx flash ``` The following video shows the test. **Please note** The test is pretty slow because the display has 480 x 320 pixels and the MCU 8080 8-bit parallel interface is realized by a GPIO-driven bit-banging implementation where each GPIO of the data bus is set separately. A follow-up PR will use the ESP32-S3 LCD controller and DMA for this board. This PR just defines the extension of the driver by the parallel interface and provides the bit-banging implementation for MCUs that don't have a LCD controller on chip. https://github.com/RIOT-OS/RIOT/assets/31932013/c1e3e3d7-05d9-4ca5-8fff-9a5eaca50fba ### Issues/PRs references Co-authored-by: Gunar Schorcht <[email protected]>

19915: drivers/lcd: support MCU 8080 8-bit parallel mode r=benpicco a=gschorcht ### Contribution description LCD driver ICs usually support - SPI serial mode, - MCU 8080 8-bit parallel mode and - MCU 8080 16-bit parallel mode. This PR extends the LCD display driver API to support the MCU 8080 8-/16-bit parallel modes and implements a GPIO-driven MCU 8080 8-bit parallel mode. The following features are already working locally and will be provided as follow-on PRs for which this PR is a prerequisite. - GPIO-driven bit-banging implementation of the 16-bit mode of the MCU 8080 parallel interface - Enabling the display on `stm32f723e-disco` and `stm32l496g-disco` using the feature above - Definition of a low-level API for the parallel modes using the LCD controller of the MCU - Using FMC for the display on `stm32f723e-disco` and `stm32l496g-disco` - Using LCD controller for the display of `esp32-wt32-sc01-plus` (PR #19917) ### Testing procedure The PR can be tested with PR #19917 on top of this PR. ``` BOARD=esp32s3-wt32-sc01-plus make -j8 -C tests/drivers/st77xx flash ``` The following video shows the test. **Please note** The test is pretty slow because the display has 480 x 320 pixels and the MCU 8080 8-bit parallel interface is realized by a GPIO-driven bit-banging implementation where each GPIO of the data bus is set separately. A follow-up PR will use the ESP32-S3 LCD controller and DMA for this board. This PR just defines the extension of the driver by the parallel interface and provides the bit-banging implementation for MCUs that don't have a LCD controller on chip. https://github.com/RIOT-OS/RIOT/assets/31932013/c1e3e3d7-05d9-4ca5-8fff-9a5eaca50fba ### Issues/PRs references Co-authored-by: Gunar Schorcht <[email protected]>

19914: boards: complete SD Card MTD definition for several bords r=benpicco a=gschorcht ### Contribution description This PR completes the MTD definition for the following boards: - `seeedstudio-gd32` - `sipeed-longan-nano` including `sipeed-longan-nano-tft` - `waveshare-nrf52840-eval-kit` - ESP32x boards that have an SPI SD Card interface and use `mtd_sdcard_default` ### Testing procedure Green CI ### Issues/PRs references#19465 Prerequisite for PR #19465 19915: drivers/lcd: support MCU 8080 8-bit parallel mode r=benpicco a=gschorcht ### Contribution description LCD driver ICs usually support - SPI serial mode, - MCU 8080 8-bit parallel mode and - MCU 8080 16-bit parallel mode. This PR extends the LCD display driver API to support the MCU 8080 8-/16-bit parallel modes and implements a GPIO-driven MCU 8080 8-bit parallel mode. The following features are already working locally and will be provided as follow-on PRs for which this PR is a prerequisite. - GPIO-driven bit-banging implementation of the 16-bit mode of the MCU 8080 parallel interface - Enabling the display on `stm32f723e-disco` and `stm32l496g-disco` using the feature above - Definition of a low-level API for the parallel modes using the LCD controller of the MCU - Using FMC for the display on `stm32f723e-disco` and `stm32l496g-disco` - Using LCD controller for the display of `esp32-wt32-sc01-plus` (PR #19917) ### Testing procedure The PR can be tested with PR #19917 on top of this PR. ``` BOARD=esp32s3-wt32-sc01-plus make -j8 -C tests/drivers/st77xx flash ``` The following video shows the test. **Please note** The test is pretty slow because the display has 480 x 320 pixels and the MCU 8080 8-bit parallel interface is realized by a GPIO-driven bit-banging implementation where each GPIO of the data bus is set separately. A follow-up PR will use the ESP32-S3 LCD controller and DMA for this board. This PR just defines the extension of the driver by the parallel interface and provides the bit-banging implementation for MCUs that don't have a LCD controller on chip. https://github.com/RIOT-OS/RIOT/assets/31932013/c1e3e3d7-05d9-4ca5-8fff-9a5eaca50fba ### Issues/PRs references Co-authored-by: Gunar Schorcht <[email protected]>

drivers/st77xx/st77xx.c

benpicco

Nice addition, all pretty straightforward.

benpicco · 2023-09-21T10:05:18Z

bors merge

bors · 2023-09-21T10:05:22Z

👎 Rejected by PR status

benpicco · 2023-09-21T10:06:53Z

bors why?

gschorcht · 2023-09-21T10:12:32Z

As I remeber, rebasing should help.

benpicco · 2023-09-21T10:54:07Z

bors merge

bors · 2023-09-21T14:43:05Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

gschorcht · 2023-09-22T05:49:09Z

@benpicco Thanks

gschorcht requested review from MichelRottleuthner, MrKevinWeiss, aabadie, fjmolinas, jia200x, leandrolanzieri and smlng as code owners September 7, 2023 10:55

github-actions bot added Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration labels Sep 7, 2023

gschorcht mentioned this pull request Sep 7, 2023

drivers/lcd: support MCU 8080 8-bit parallel mode #19915

Merged

gschorcht added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 7, 2023

gschorcht force-pushed the boards/esp32s3-wt32-sc01-plus branch 2 times, most recently from 677b2e5 to 62f4784 Compare September 7, 2023 11:28

gschorcht added the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 7, 2023

gschorcht force-pushed the boards/esp32s3-wt32-sc01-plus branch from 62f4784 to 1d2b901 Compare September 8, 2023 06:23

gschorcht added this to the Release 2023.10 milestone Sep 15, 2023

github-actions bot added the Area: drivers Area: Device drivers label Sep 20, 2023

benpicco reviewed Sep 21, 2023

View reviewed changes

drivers/st77xx/st77xx.c Show resolved Hide resolved

benpicco approved these changes Sep 21, 2023

View reviewed changes

gschorcht added 3 commits September 21, 2023 12:14

boards: add ESP32-S3-WT32-SC01-Plus support

9b30c65

tests/drivers/st77xx: add esp32s3-wt32-sc01-plus

f6a7611

drivers/st77xx: fix init for ST7796

65d937c

gschorcht force-pushed the boards/esp32s3-wt32-sc01-plus branch from b5d7239 to 65d937c Compare September 21, 2023 10:15

bors bot merged commit 19efd67 into RIOT-OS:master Sep 21, 2023

gschorcht deleted the boards/esp32s3-wt32-sc01-plus branch September 22, 2023 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

boards: add support for ESP32-S3 WT32 SC01 Plus board #19917

boards: add support for ESP32-S3 WT32 SC01 Plus board #19917

Uh oh!

gschorcht commented Sep 7, 2023

Uh oh!

riot-ci commented Sep 7, 2023 •

edited

Loading

Uh oh!

Uh oh!

benpicco left a comment

Uh oh!

benpicco commented Sep 21, 2023

Uh oh!

bors bot commented Sep 21, 2023

Uh oh!

benpicco commented Sep 21, 2023

Uh oh!

gschorcht commented Sep 21, 2023

Uh oh!

benpicco commented Sep 21, 2023

Uh oh!

bors bot commented Sep 21, 2023

Uh oh!

gschorcht commented Sep 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

boards: add support for ESP32-S3 WT32 SC01 Plus board #19917

boards: add support for ESP32-S3 WT32 SC01 Plus board #19917

Uh oh!

Conversation

gschorcht commented Sep 7, 2023

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

riot-ci commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

benpicco commented Sep 21, 2023

Uh oh!

bors bot commented Sep 21, 2023

Uh oh!

benpicco commented Sep 21, 2023

Uh oh!

gschorcht commented Sep 21, 2023

Uh oh!

benpicco commented Sep 21, 2023

Uh oh!

bors bot commented Sep 21, 2023

Uh oh!

gschorcht commented Sep 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

riot-ci commented Sep 7, 2023 •

edited

Loading