-
Notifications
You must be signed in to change notification settings - Fork 2.1k
boards,sys/arduino: major clean up #19759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b783a36 to
63d4fd7
Compare
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 14, 2025
`arduino_pinmap` and `arduino__analog_map` are not defined any longer by the board but as a common approach in `sys/arduino/include/arduino_board*.h`. Their definition in `boards/common/esp32x` were just a leftover and forgotten in PR RIOT-OS#19759.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
Migration to the new Arduino I/O mapping, which was not fully covered in PR RIOT-OS#19759 when the new Arduino I/O mapping was introduced and the feature handling was changed.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
May 19, 2025
`arduino_pinmap` and `arduino__analog_map` are not defined any longer by the board but as a common approach in `sys/arduino/include/arduino_board*.h`. Their definition in `boards/common/esp32x` were just a leftover and forgotten in PR RIOT-OS#19759.
Contributor
|
@maribu Was there any reason why the features |
Member
Author
|
Just to avoid growing the PRs scope. But if seems I never came back to adding those later on 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: arduino API
Area: Arduino wrapper API
Area: boards
Area: Board ports
Area: doc
Area: Documentation
Area: drivers
Area: Device drivers
Area: Kconfig
Area: Kconfig integration
Area: sys
Area: System
Area: tests
Area: tests and testing framework
Area: tools
Area: Supplementary tools
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
arduino_pinmap.htoarduino_iomap.harduino_pinmap.hthat just includesarduino_iomap.his provided for backward compatibilityarduino_board.hinto the new file as trivial macros, so that they can also be used outside of sketchesarduino_board.harduino_board.handarduino_iomap.hnow provide the exact same information, just in a different formatarduino_board.his provided instead that just uses the info inarduinio_iomap.hand provides them in the format the code insys/arduinoexpects itarduino_pins:ARDUINO_PIN_0etc. are availablearduino_analog:ARDUINO_A0etc. are availablearduino_pwm:ARDUINO_PIN_13_PWM_DEVetc. are availablearduino_dac:ARDUINO_DAC0etc. are availablearduino_uart:ARDUINO_UART_D0D1or similar are availablearduino_spi:ARDUINO_SPI_ISPor similar are availablearduino_i2c:ARDUINO_I2C_UNOor similar are availablearuino_shield_nano: Arduino NANO compatible headersaruino_shield_uno: Arduino UNO compatible headersaruino_shield_mega: Arduino MEGA compatible headersaruino_shield_isp: ISP header is availableThis provides the groundwork to implement shield support as modules that can rely on the I/O mappings, rather than having to provide a configuration per board.
Testing procedure
CI + lots of code review ...
In the long term the peripheral self testing shield will allow automatic testing for some of the I/O mappings for Arduino UNO compatible boards. But this PR would be required first for any soft of meaningful shield support in RIOT first.
Issues/PRs references
None