netdev_drivers: make sure to signal LINK_UP at least once

benpicco · benpicco · commit a4a9cab838ac · 2022-09-16T13:12:30.000+02:00
diff --git a/cpu/esp_common/esp-now/esp_now_netdev.c b/cpu/esp_common/esp-now/esp_now_netdev.c
@@ -487,6 +487,9 @@ static int _init(netdev_t *netdev)
 {
     DEBUG("%s: %p\n", __func__, netdev);
 
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/cpu/native/netdev_tap/netdev_tap.c b/cpu/native/netdev_tap/netdev_tap.c
@@ -404,5 +404,9 @@ static int _init(netdev_t *netdev)
     native_async_read_add_handler(dev->tap_fd, netdev, _tap_isr);
 
     DEBUG("gnrc_tapnet: initialized.\n");
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
diff --git a/cpu/nrf5x_common/radio/nrfble/nrfble.c b/cpu/nrf5x_common/radio/nrfble/nrfble.c
@@ -279,6 +279,10 @@ static int _nrfble_init(netdev_t *dev)
     NVIC_EnableIRQ(RADIO_IRQn);
 
     DEBUG("[nrfble] initialization successful\n");
+
+    /* signal link UP */
+    dev->event_callback(dev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/cpu/nrf5x_common/radio/nrfmin/nrfmin.c b/cpu/nrf5x_common/radio/nrfmin/nrfmin.c
@@ -448,6 +448,9 @@ static int nrfmin_init(netdev_t *dev)
 
     DEBUG("[nrfmin] initialization successful\n");
 
+    /* signal link UP */
+    dev->event_callback(dev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/cpu/sam0_common/sam0_eth/eth-netdev.c b/cpu/sam0_common/sam0_eth/eth-netdev.c
@@ -54,6 +54,10 @@ static int _sam0_eth_init(netdev_t *netdev)
     eui48_t hwaddr;
     netdev_eui48_get(netdev, &hwaddr);
     sam0_eth_set_mac(&hwaddr);
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/cpu/stm32/periph/eth.c b/cpu/stm32/periph/eth.c
@@ -460,6 +460,11 @@ static int stm32_eth_init(netdev_t *netdev)
 
     _setup_phy();
 
+    /* signal link UP if no proper link detection is enabled */
+    if (!IS_USED(MODULE_STM32_ETH_LINK_UP)) {
+        netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+    }
+
     return 0;
 }
 
diff --git a/drivers/at86rf215/at86rf215_netdev.c b/drivers/at86rf215/at86rf215_netdev.c
@@ -137,6 +137,9 @@ static int _init(netdev_t *netdev)
     /* reset device to default values and put it into RX state */
     at86rf215_reset_and_cfg(dev);
 
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/at86rf2xx/at86rf2xx_netdev.c b/drivers/at86rf2xx/at86rf2xx_netdev.c
@@ -108,6 +108,9 @@ static int _init(netdev_t *netdev)
     /* reset device to default values and put it into RX state */
     at86rf2xx_reset(dev);
 
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/cc110x/cc110x_netdev.c b/drivers/cc110x/cc110x_netdev.c
@@ -343,6 +343,10 @@ static int cc110x_init(netdev_t *netdev)
     }
 
     DEBUG("[cc110x] netdev_driver_t::init(): Success\n");
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/cc2420/cc2420_netdev.c b/drivers/cc2420/cc2420_netdev.c
@@ -136,7 +136,13 @@ static int _init(netdev_t *netdev)
         return -1;
     }
 
-    return cc2420_init(dev);
+    int res = cc2420_init(dev);
+    if (res == 0) {
+        /* signal link UP */
+        netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+    }
+
+    return res;
 }
 
 static void _isr(netdev_t *netdev)
diff --git a/drivers/dose/dose.c b/drivers/dose/dose.c
@@ -752,6 +752,8 @@ static int _init(netdev_t *dev)
 
     state(ctx, DOSE_SIGNAL_INIT);
 
+    dev->event_callback(dev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/ethos/ethos.c b/drivers/ethos/ethos.c
@@ -211,9 +211,11 @@ static void _isr(netdev_t *netdev)
     netdev->event_callback(netdev, NETDEV_EVENT_RX_COMPLETE);
 }
 
-static int _init(netdev_t *encdev)
+static int _init(netdev_t *netdev)
 {
-    (void)encdev;
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/kw41zrf/kw41zrf_netdev.c b/drivers/kw41zrf/kw41zrf_netdev.c
@@ -100,6 +100,9 @@ static int kw41zrf_netdev_init(netdev_t *netdev)
         return -1;
     }
 
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/mrf24j40/mrf24j40_netdev.c b/drivers/mrf24j40/mrf24j40_netdev.c
@@ -64,6 +64,9 @@ static int _init(netdev_t *netdev)
         return -ENODEV;
     }
 
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/netdev_ieee802154_submac/netdev_ieee802154_submac.c b/drivers/netdev_ieee802154_submac/netdev_ieee802154_submac.c
@@ -365,6 +365,10 @@ static int _init(netdev_t *netdev)
                           &enable, sizeof(enable));
 
     netdev_submac->dev.txpower = tx_power;
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/nrf24l01p_ng/nrf24l01p_ng_netdev.c b/drivers/nrf24l01p_ng/nrf24l01p_ng_netdev.c
@@ -255,6 +255,10 @@ static int _init(netdev_t *netdev)
         DEBUG_PUTS("[nrf24l01p_ng] _init(): gpio_init_int() failed");
         return -EIO;
     }
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/slipdev/slipdev.c b/drivers/slipdev/slipdev.c
@@ -87,6 +87,10 @@ static int _init(netdev_t *netdev)
                   dev->config.uart, dev->config.baudrate);
         return -ENODEV;
     }
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/sx126x/sx126x_netdev.c b/drivers/sx126x/sx126x_netdev.c
@@ -141,6 +141,10 @@ static int _init(netdev_t *netdev)
     }
 
     DEBUG("[sx126x] netdev: initialization successful\n");
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/sx127x/sx127x_netdev.c b/drivers/sx127x/sx127x_netdev.c
@@ -229,6 +229,9 @@ static int _init(netdev_t *netdev)
 
     DEBUG("[sx127x] netdev: initialization done\n");
 
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/sx1280/sx1280_netdev.c b/drivers/sx1280/sx1280_netdev.c
@@ -149,6 +149,10 @@ static int _init(netdev_t *netdev)
     }
 
     DEBUG("[sx1280] netdev: initialization successful\n");
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/w5100/w5100.c b/drivers/w5100/w5100.c
@@ -180,6 +180,9 @@ static int init(netdev_t *netdev)
     /* release the SPI bus again */
     spi_release(dev->p.spi);
 
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/drivers/xbee/xbee.c b/drivers/xbee/xbee.c
@@ -639,6 +639,10 @@ int xbee_init(netdev_t *dev)
     }
 
     DEBUG("[xbee] init: Initialization successful\n");
+
+    /* signal link UP */
+    dev->event_callback(dev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 
diff --git a/sys/usb/usbus/cdc/ecm/cdc_ecm_netdev.c b/sys/usb/usbus/cdc/ecm/cdc_ecm_netdev.c
@@ -154,6 +154,10 @@ static int _init(netdev_t *netdev)
     usbus_cdcecm_device_t *cdcecm = _netdev_to_cdcecm(netdev);
 
     luid_get_eui48((eui48_t*)cdcecm->mac_netdev);
+
+    /* signal link UP */
+    netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);
+
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -487,6 +487,9 @@ static int _init(netdev_t *netdev)`
`487`	`487`	`{`
`488`	`488`	`DEBUG("%s: %p\n", __func__, netdev);`
`489`	`489`
	`490`	`+ /* signal link UP */`
	`491`	`+ netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);`
	`492`	`+`
`490`	`493`	`return 0;`
`491`	`494`	`}`
`492`	`495`
Original file line number	Diff line number	Diff line change
`@@ -404,5 +404,9 @@ static int _init(netdev_t *netdev)`
`404`	`404`	`native_async_read_add_handler(dev->tap_fd, netdev, _tap_isr);`
`405`	`405`
`406`	`406`	`DEBUG("gnrc_tapnet: initialized.\n");`
	`407`	`+`
	`408`	`+ /* signal link UP */`
	`409`	`+ netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);`
	`410`	`+`
`407`	`411`	`return 0;`
`408`	`412`	`}`
Original file line number	Diff line number	Diff line change
`@@ -279,6 +279,10 @@ static int _nrfble_init(netdev_t *dev)`
`279`	`279`	`NVIC_EnableIRQ(RADIO_IRQn);`
`280`	`280`
`281`	`281`	`DEBUG("[nrfble] initialization successful\n");`
	`282`	`+`
	`283`	`+ /* signal link UP */`
	`284`	`+ dev->event_callback(dev, NETDEV_EVENT_LINK_UP);`
	`285`	`+`
`282`	`286`	`return 0;`
`283`	`287`	`}`
`284`	`288`
Original file line number	Diff line number	Diff line change
`@@ -448,6 +448,9 @@ static int nrfmin_init(netdev_t *dev)`
`448`	`448`
`449`	`449`	`DEBUG("[nrfmin] initialization successful\n");`
`450`	`450`
	`451`	`+ /* signal link UP */`
	`452`	`+ dev->event_callback(dev, NETDEV_EVENT_LINK_UP);`
	`453`	`+`
`451`	`454`	`return 0;`
`452`	`455`	`}`
`453`	`456`
Original file line number	Diff line number	Diff line change
`@@ -460,6 +460,11 @@ static int stm32_eth_init(netdev_t *netdev)`
`460`	`460`
`461`	`461`	`_setup_phy();`
`462`	`462`
	`463`	`+ /* signal link UP if no proper link detection is enabled */`
	`464`	`+ if (!IS_USED(MODULE_STM32_ETH_LINK_UP)) {`
	`465`	`+ netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);`
	`466`	`+ }`
	`467`	`+`
`463`	`468`	`return 0;`
`464`	`469`	`}`
`465`	`470`
Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,9 @@ static int _init(netdev_t *netdev)`
`137`	`137`	`/* reset device to default values and put it into RX state */`
`138`	`138`	`at86rf215_reset_and_cfg(dev);`
`139`	`139`
	`140`	`+ /* signal link UP */`
	`141`	`+ netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);`
	`142`	`+`
`140`	`143`	`return 0;`
`141`	`144`	`}`
`142`	`145`
Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,9 @@ static int _init(netdev_t *netdev)`
`108`	`108`	`/* reset device to default values and put it into RX state */`
`109`	`109`	`at86rf2xx_reset(dev);`
`110`	`110`
	`111`	`+ /* signal link UP */`
	`112`	`+ netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);`
	`113`	`+`
`111`	`114`	`return 0;`
`112`	`115`	`}`
`113`	`116`
Original file line number	Diff line number	Diff line change
`@@ -343,6 +343,10 @@ static int cc110x_init(netdev_t *netdev)`
`343`	`343`	`}`
`344`	`344`
`345`	`345`	`DEBUG("[cc110x] netdev_driver_t::init(): Success\n");`
	`346`	`+`
	`347`	`+ /* signal link UP */`
	`348`	`+ netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);`
	`349`	`+`
`346`	`350`	`return 0;`
`347`	`351`	`}`
`348`	`352`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,13 @@ static int _init(netdev_t *netdev)`
`136`	`136`	`return -1;`
`137`	`137`	`}`
`138`	`138`
`139`		`- return cc2420_init(dev);`
	`139`	`+ int res = cc2420_init(dev);`
	`140`	`+ if (res == 0) {`
	`141`	`+ /* signal link UP */`
	`142`	`+ netdev->event_callback(netdev, NETDEV_EVENT_LINK_UP);`
	`143`	`+ }`
	`144`	`+`
	`145`	`+ return res;`
`140`	`146`	`}`
`141`	`147`
`142`	`148`	`static void _isr(netdev_t *netdev)`