move notify to be contained in submod

Author: Teufelchen1

drivers/slipmux/coap.c

@@ -29,10 +29,10 @@ static event_queue_t queue;
 static uint8_t buf[CONFIG_SLIPMUX_COAP_BUFSIZE];
 
 /* called in ISR context */
-void _slipmux_coap_dispatch_recv(event_t *event)
+void slipmux_coap_notify(slipmux_t *dev)
 {
     if (queue.waiter) {
-        event_post(&queue, event);
+        event_post(&queue, &dev->event);
     }
 }
 

drivers/slipmux/include/slipmux_internal.h

@@ -169,10 +169,38 @@ static inline void slipmux_unlock(void)
 }
 
 #if IS_USED(MODULE_SLIPMUX_COAP)
+/**
+ * @brief   Initialise the CoAP handling
+ * 
+ * @param[in] dev  The Slipmux device to initialise.
+ * @param[in] index  Device number.
+ */
 void slipmux_coap_init(slipmux_t *dev, unsigned index);
+
+/**
+ * @brief   Inform the CoAP server there is new work to do.
+ *          Called in ISR context!
+ *
+ * @param[in] dev  The Slipmux device to notify.
+ */
+void slipmux_coap_notify(slipmux_t *dev);
 #endif
 #if IS_USED(MODULE_SLIPMUX_NET)
+/**
+ * @brief   Initialise the network handling
+ * 
+ * @param[in] dev  The Slipmux device to initialise.
+ * @param[in] index  Device number.
+ */
 void slipmux_net_init(slipmux_t *dev, unsigned index);
+
+/**
+ * @brief   Inform the Network interface there is new work to do.
+ *          Called in ISR context!
+ *
+ * @param[in] dev  The Slipmux device to notify.
+ */
+void slipmux_net_notify(slipmux_t *dev);
 #endif
 
 #ifdef __cplusplus

drivers/slipmux/net.c

@@ -216,7 +216,13 @@ static const netdev_driver_t slip_driver = {
 #endif
 };
 
-void slipmux_net_init(slipmux_t * dev, unsigned index) {
+void slipmux_net_notify(slipmux_t *dev)
+{
+    netdev_trigger_event_isr(&dev->netdev);
+}
+
+void slipmux_net_init(slipmux_t * dev, unsigned index)
+{
     dev->netdev.driver = &slip_driver;
     crb_init(&dev->net_rb, dev->net_rx, sizeof(dev->net_rx));
     netdev_register(&dev->netdev, NETDEV_SLIPDEV, index);

drivers/slipmux/slipmux.c

@@ -81,8 +81,7 @@ void slipmux_rx_cb(void *arg, uint8_t byte)
             dev->state = SLIPMUX_STATE_NONE;
 #if IS_USED(MODULE_SLIPMUX_COAP)
             crb_end_chunk(&dev->coap_rb, true);
-            extern void _slipmux_coap_dispatch_recv(event_t *);
-            _slipmux_coap_dispatch_recv(&dev->event);
+            slipmux_coap_notify(dev);
 #endif
             break;
         default:
@@ -126,7 +125,7 @@ void slipmux_rx_cb(void *arg, uint8_t byte)
         case SLIPMUX_END:
 #if IS_USED(MODULE_SLIPMUX_NET)
             crb_end_chunk(&dev->net_rb, true);
-            netdev_trigger_event_isr(&dev->netdev);
+            slipmux_net_notify(dev);
 #endif
             dev->state = SLIPMUX_STATE_NONE;
             return;