chore: clippy fixes

Author: ss2165

hugr-core/src/envelope.rs

@@ -147,12 +147,12 @@ pub fn read_described_envelope(
     reader: impl BufRead,
     registry: &ExtensionRegistry,
 ) -> Result<(PackageDesc, Package), ReadError> {
-    let reader = EnvelopeReader::new(reader, registry)?;
+    let reader = EnvelopeReader::new(reader, registry).map_err(Box::new)?;
     let (desc, res) = reader.read();
     match res {
         Ok(pkg) => Ok((desc, pkg)),
         Err(e) => Err(ReadError::Payload {
-            source: e,
+            source: Box::new(e),
             partial_description: desc,
         }),
     }
@@ -163,12 +163,12 @@ pub fn read_described_envelope(
 pub enum ReadError {
     /// Error reading the envelope header.
     #[error(transparent)]
-    EnvelopeHeader(#[from] HeaderError),
+    EnvelopeHeader(#[from] Box<HeaderError>),
     /// Error reading the package payload.
     #[error("Error reading package payload in envelope.")]
     Payload {
         /// The source error.
-        source: PayloadError,
+        source: Box<PayloadError>,
         /// Partial description of the envelope read before the error occurred.
         partial_description: PackageDesc,
     },
@@ -177,8 +177,8 @@ pub enum ReadError {
 impl From<ReadError> for EnvelopeError {
     fn from(err: ReadError) -> Self {
         match err {
-            ReadError::EnvelopeHeader(e) => e.into(),
-            ReadError::Payload { source, .. } => source.into(),
+            ReadError::EnvelopeHeader(e) => (*e).into(),
+            ReadError::Payload { source, .. } => (*source).into(),
         }
     }
 }

hugr-core/src/envelope/description.rs

@@ -461,7 +461,7 @@ mod test {
             signature: Default::default(),
         }
         .into();
-        empty_module_desc.set_entrypoint(node.clone(), optype.clone());
+        empty_module_desc.set_entrypoint(node, optype.clone());
         assert_eq!(empty_module_desc.entrypoint.as_ref().unwrap().node, node);
         assert_eq!(
             empty_module_desc.entrypoint.as_ref().unwrap().optype,

hugr-core/src/envelope/reader.rs

@@ -104,7 +104,7 @@ impl<R: BufRead> EnvelopeReader<R> {
 
     fn read_impl(&mut self) -> Result<Package, PayloadError> {
         let mut package = match self.header().format {
-            EnvelopeFormat::PackageJson => self.from_json_reader()?,
+            EnvelopeFormat::PackageJson => self.decode_json()?,
             EnvelopeFormat::Model | EnvelopeFormat::ModelWithExtensions => self.decode_model()?,
             EnvelopeFormat::ModelText | EnvelopeFormat::ModelTextWithExtensions => {
                 self.decode_model_ast()?
@@ -143,7 +143,7 @@ impl<R: BufRead> EnvelopeReader<R> {
     /// Read a Package in json format from an io reader.
     /// Returns package and the combined extension registry
     /// of the provided registry and the package extensions.
-    fn from_json_reader(&mut self) -> Result<Package, PackageEncodingError> {
+    fn decode_json(&mut self) -> Result<Package, PackageEncodingError> {
         let val: serde_json::Value = serde_json::from_reader(&mut self.reader)?;
 
         let super::package_json::PackageDeser {