xhatspecific_spoke: wire scenario_dict and all_nodenames (#586) (#707)

xhatspecific_spoke in cfg_vanilla took `scenario_dict` and `all_nodenames`
parameters but dropped both before constructing the spoke dict, so callers
got "missing data" errors at runtime:

* `all_nodenames` was not forwarded to _Xhat_Eval_spoke_foundation (sibling
  spokes like xhatshuffle_spoke already forward it).
* `scenario_dict` should populate
  opt_kwargs.options.xhat_specific_options.xhat_scenario_dict, which the
  XhatSpecificInnerBound bounder reads at startup. Nothing was setting
  that key, so the bounder hit a KeyError before it could try a candidate.

Fix:
- Forward all_nodenames through to _Xhat_Eval_spoke_foundation.
- Populate xhat_specific_options with xhat_scenario_dict (from the
  argument) and xhat_solver_options (mirroring xhatlooper_spoke's pattern
  of reusing iterk_solver_options).

Also fix the only known caller, examples/aircond/aircond_cylinders.py:
when `--solver-options` is passed alongside `--xhatspecific`, the override
loop reached into `xhat_looper_options` (which xhatspecific does not have)
instead of `xhat_specific_options`. Post-factory-fix this would still
KeyError; rename to the correct key.

Fixes #586

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: DLWoodruff

examples/aircond/aircond_cylinders.py

@@ -315,7 +315,7 @@ def main():
             sd["opt_kwargs"]["options"]["iterk_solver_options"].update(soptions)
 
         if with_xhatspecific:
-            xhatspecific_spoke["opt_kwargs"]["options"]["xhat_looper_options"]["xhat_solver_options"].update(soptions)
+            xhatspecific_spoke["opt_kwargs"]["options"]["xhat_specific_options"]["xhat_solver_options"].update(soptions)
         if with_xhatshuffle:
             xhatshuffle_spoke["opt_kwargs"]["options"]["xhat_looper_options"]["xhat_solver_options"].update(soptions)
     # special code to get a trace for xhatshuffle

mpisppy/utils/cfg_vanilla.py

@@ -1258,10 +1258,16 @@ def xhatspecific_spoke(
         scenario_creator,
         scenario_denouement,
         all_scenario_names,
+        all_nodenames=all_nodenames,
         scenario_creator_kwargs=scenario_creator_kwargs,
         ph_extensions=ph_extensions,
         extension_kwargs=extension_kwargs,
     )
+    xhatspecific_dict["opt_kwargs"]["options"]["xhat_specific_options"] = {
+        "xhat_solver_options": xhatspecific_dict["opt_kwargs"]["options"]["iterk_solver_options"],
+        "xhat_scenario_dict": scenario_dict,
+        "csvname": "specific.csv",
+    }
     _maybe_attach_jensens(xhatspecific_dict, cfg, "xhatspecific",
                           average_scenario_creator, scenario_creator_kwargs)
     return xhatspecific_dict