update ceccloader.h & make cmake obey INSTALL_BINDIR & INSTALL_LIBDIR#683
Merged
opdenkamp merged 2 commits intoPulse-Eight:masterfrom Jun 17, 2025
Merged
Conversation
chincheta0815
changed the title
opdenkamp
reviewed
Jun 17, 2025
| int (CDECL *open)(libcec_connection_t connection, const char* strPort, uint32_t iTimeout); | ||
| void (CDECL *close)(libcec_connection_t connection); | ||
| void (CDECL *clear_configuration)(CEC_NAMESPACE libcec_configuration* configuration); | ||
| #if CEC_LIB_VERSION_MAJOR >= 5 |
Contributor
There was a problem hiding this comment.
these ifdefs can go really because there's no good reason to keep the latest cecloader.h compatible with older versions of libCEC. those builds can use the previous revisions of cecloader.h. I'll merge it anyway now, but I'll remove the ifdefs later unless someone can provide a good reason for keeping these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parts from #672