Skip to content

Commit 6a97aeb

Browse files
Don't wait for ACL rules with Broadcom ASICs (sonic-net#1038)
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: With Broadcom ASICs, don't wait for the ACL rule counters to change from 'N/A' to 0 since it isn't needed (and will cause the test to time out and fail). ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement Signed-off-by: Fraser Gordon <[email protected]>
1 parent d28f241 commit 6a97aeb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/everflow/everflow_test_utilities.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,7 @@ def apply_non_openconfig_acl_rle(self, duthost, extra_vars, rule_file):
792792
duthost.template(src=os.path.join(FILE_DIR, rule_file), dest=dest_path)
793793
duthost.shell("config load -y {}".format(dest_path))
794794

795-
if duthost.facts['asic_type'] != 'vs':
795+
if duthost.facts['asic_type'] not in ['vs', 'broadcom']:
796796
pytest_assert(wait_until(60, 2, 0, self.check_rule_counters, duthost), "Acl rule counters are not ready")
797797

798798
def apply_ip_type_rule(self, duthost, ip_version):

0 commit comments

Comments
 (0)