feat(GODT-2829): Extend Metadata with some missing features

* Allow sorting in descending order
* Add `EndID` parameter to match in query.

Author: LBeernaertProton

message.go

@@ -248,15 +248,13 @@ func (c *Client) GetMessageMetadataPage(ctx context.Context, page, pageSize int,
 		PageSize int
 
 		Sort string
-		Desc Bool
 	}{
 		MessageFilter: filter,
 
 		Page:     page,
 		PageSize: pageSize,
 
 		Sort: "ID",
-		Desc: false,
 	}
 
 	for {

message_types.go

@@ -54,6 +54,8 @@ type MessageFilter struct {
 	AddressID  string `json:",omitempty"`
 	ExternalID string `json:",omitempty"`
 	LabelID    string `json:",omitempty"`
+	EndID      string `json:",omitempty"`
+	Desc       Bool
 }
 
 type Message struct {

server/backend/api.go

@@ -360,6 +360,23 @@ func (b *Backend) GetMessages(userID string, page, pageSize int, filter proton.M
 				return nil, err
 			}
 
+			if filter.Desc {
+				xslices.Reverse(metadata)
+			}
+
+			// Note that this not a perfect replacement as we don't handle the case where this message could have been
+			// deleted in between this metadata request. The backend has the information stored differently and can
+			// resolve these gaps.
+			if filter.EndID != "" {
+				index := xslices.IndexFunc(metadata, func(metadata proton.MessageMetadata) bool {
+					return metadata.ID == filter.EndID
+				})
+
+				if index >= 0 {
+					metadata = metadata[index:]
+				}
+			}
+
 			metadata = xslices.Filter(metadata, func(metadata proton.MessageMetadata) bool {
 				if len(filter.ID) > 0 {
 					if !slices.Contains(filter.ID, metadata.ID) {
@@ -548,7 +565,6 @@ func (b *Backend) CreateDraft(userID, addrID string, draft proton.DraftTemplate,
 					}
 				}
 				msg := newMessageFromTemplate(addrID, draft, parentRef)
-
 				// Drafts automatically get the sysLabel "Drafts".
 				msg.addLabel(proton.DraftsLabel, labels)
 

server/backend/backend.go

@@ -2,7 +2,6 @@ package backend
 
 import (
 	"fmt"
-	"golang.org/x/exp/slices"
 	"net/mail"
 	"sync"
 	"time"
@@ -14,6 +13,7 @@ import (
 	"github.com/bradenaw/juniper/xslices"
 	"github.com/google/uuid"
 	"golang.org/x/exp/maps"
+	"golang.org/x/exp/slices"
 )
 
 type Backend struct {

server/server_test.go

@@ -233,6 +233,44 @@ func TestServer_MessageFilter(t *testing.T) {
 	})
 }
 
+func TestServer_MessageFilterDesc(t *testing.T) {
+	withServer(t, func(ctx context.Context, s *Server, m *proton.Manager) {
+		withUser(ctx, t, s, m, "user", "pass", func(c *proton.Client) {
+			withMessages(ctx, t, c, "pass", 100, func(messageIDs []string) {
+				allMetadata := make([]proton.MessageMetadata, 0, 100)
+
+				// first request.
+				{
+					metadata, err := c.GetMessageMetadataPage(ctx, 0, 10, proton.MessageFilter{Desc: true})
+					require.NoError(t, err)
+
+					allMetadata = append(allMetadata, metadata...)
+				}
+
+				for i := 1; i < 11; i++ {
+					// Get the messages.
+					metadata, err := c.GetMessageMetadataPage(ctx, 0, 10, proton.MessageFilter{Desc: true, EndID: allMetadata[len(allMetadata)-1].ID})
+					require.NoError(t, err)
+					require.NotEmpty(t, metadata)
+					require.Equal(t, metadata[0].ID, allMetadata[len(allMetadata)-1].ID)
+					allMetadata = append(allMetadata, metadata[1:]...)
+				}
+
+				// Final check. Asking for EndID as last message multiple times will always return the last id.
+				metadata, err := c.GetMessageMetadataPage(ctx, 0, 10, proton.MessageFilter{Desc: true, EndID: allMetadata[len(allMetadata)-1].ID})
+				require.NoError(t, err)
+				require.Len(t, metadata, 1)
+				require.Equal(t, metadata[0].ID, allMetadata[len(allMetadata)-1].ID)
+
+				// The messages should be the ones we created.
+				require.ElementsMatch(t, messageIDs, xslices.Map(allMetadata, func(metadata proton.MessageMetadata) string {
+					return metadata.ID
+				}))
+			})
+		})
+	})
+}
+
 func TestServer_MessageIDs(t *testing.T) {
 	withServer(t, func(ctx context.Context, s *Server, m *proton.Manager) {
 		withUser(ctx, t, s, m, "user", "pass", func(c *proton.Client) {