Skip to content

Expiration parameter #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
klische wants to merge 5 commits into from
Closed

Expiration parameter #56

klische wants to merge 5 commits into from

Conversation

@klische
Copy link

@klische klische commented Jul 3, 2020

In service of ProtonMail/gopenpgp#54

@klische klische mentioned this pull request Jul 3, 2020
Closed
@twiss
Copy link
Member

twiss commented Jul 6, 2020

Hey 👋 Thanks for your PRs! 👍

Some people use ProtonMail/crypto directly, so we want to keep a stable API here as well. Could you, instead of adding a parameter to NewEntity, add a field to packet.Config?

@twiss
Copy link
Member

twiss commented Jul 31, 2020

Hey @klische 👋 Gentle reminder, are you still interested in, and do you still have time for, updating this PR?

@trishankatdatadog
Copy link
Contributor

trishankatdatadog commented Oct 20, 2020

My PRs #60 and #64 should fix this. Once the latter is closed, we should close this one, too.

@trishankatdatadog
Copy link
Contributor

trishankatdatadog commented Nov 12, 2020

@twiss We can probably close this now thanks to #64?

@twiss twiss closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klische @twiss @trishankatdatadog