Fix missing required parameters in run_task API Call
#19335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated ECSWorker to explicitly include cluster and launchType in the task_run_request if specified in the configuration. - Added tests to verify that these parameters are correctly passed to the run_task API call, including scenarios where they are missing from the template.
…nes in docstring for clarity.
desertaxle
changed the title
run_task API Call
Fix ECS worker missing cluster and launchType parameters in run_task API call This PR fixes issue where ECS worker fails to pass cluster and launchType parameters to AWS ECS run_task API calls, even when correctly configured in the work pool. <details> <summary>Changes</summary> - Modified to explicitly ensure cluster and launchType are included in the task run request - Added logic to add cluster from configuration.cluster if missing or empty - Added logic to default launchType to FARGATE if missing or empty (matching the default launch_type variable) - Ensures these parameters are included even when template variables resolve to empty/None - Preserves existing behavior where launchType is removed when capacity provider strategy is set </details> Related: #19320
zzstoatzz
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19320